Skip to content

Conversation

@mbbush
Copy link
Collaborator

@mbbush mbbush commented Mar 19, 2025

Description of your changes

I choose v5.91.0 because it was the most recent at the time I started. I don't see any reason why I won't update to the most recent again before getting this ready.

The two largest issues I ran into when upgrading the terraform provider version are:

  • The upstream terraform provider no longer compiles when the mq_user resource is added. I fixed it with a minor change to the patches, but I don't have a good way to test the resource.
  • The s3_bucket_lifecycle_configuration resource was moved from the terraform sdk to the terraform plugin framework. Simply moving its external name configuration caused errors during codegen, so I've removed it completely on this branch. I'm adding it back in [draft] Re-implement s3 bucket lifecycle configuration using framework with new schema #1765, which I may just merge into here once I get it working.

Still TODO (among other things)

  • Add back the s3 bucket lifecycle configuration resource and test it
  • Validate/document the behavior of existing s3 bucket lifecycle configuration resources during a provider version upgrade. Given the reasons behind the terraform provider re-implementation (AWS api changes that couldn't be correctly handled with the sdk: I think it had something to do with nullability) there may be some nuance here.
  • Check for schema changes in other resources
  • Go through the terraform provider release notes and see if there's anything concerning. If so, validate it.
  • Do we need special handling for the write-only version of attributes? Instance.rds and secretsmanager.SecretVersion are examples. It seems like we should probably remove them entirely from the CRDs.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

@mbbush mbbush force-pushed the matt/terraform-provider-5.91 branch from dfdb5ca to 6b711fe Compare March 19, 2025 01:41
@mbbush mbbush force-pushed the matt/terraform-provider-5.91 branch from 6b711fe to e00ed19 Compare March 19, 2025 16:46
@mbbush mbbush force-pushed the matt/terraform-provider-5.91 branch from e00ed19 to cd469d8 Compare March 25, 2025 02:14
@github-actions
Copy link

github-actions bot commented Jul 5, 2025

This provider repo does not have enough maintainers to address every pull request. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Jul 5, 2025
@github-actions
Copy link

This pull request is being closed since there has been no activity for 14 days since marking it as stale. If you're still working on this, feel free to reopen the PR or create a new one!

@github-actions github-actions bot closed this Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant