Skip to content

Conversation

@maxnoe
Copy link
Member

@maxnoe maxnoe commented Dec 3, 2021

Now with the decision for gammapy and gammapy 0.19, I think we can start relying more on gammapy itself.

This will solve several issues

  • Avoid duplicated code like spectral models and io
  • Better data structures than just a bunch of quantities / numpy arrays by directly using gammapy irf classes

Specifically, this should – once completed – fix issues #151 #48 #21 #31

@maxnoe maxnoe requested a review from HealthyPear as a code owner December 3, 2021 17:48
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #170 (6565f0c) into master (934f2da) will decrease coverage by 0.29%.
The diff coverage is 98.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   91.10%   90.80%   -0.30%     
==========================================
  Files          41       41              
  Lines        1607     1566      -41     
==========================================
- Hits         1464     1422      -42     
- Misses        143      144       +1     
Impacted Files Coverage Δ
pyirf/gammapy.py 92.85% <ø> (ø)
pyirf/irf/effective_area.py 95.65% <90.00%> (-4.35%) ⬇️
pyirf/irf/energy_dispersion.py 100.00% <100.00%> (ø)
pyirf/irf/psf.py 100.00% <100.00%> (ø)
pyirf/irf/tests/test_effective_area.py 100.00% <100.00%> (ø)
pyirf/irf/tests/test_energy_dispersion.py 100.00% <100.00%> (ø)
pyirf/irf/tests/test_psf.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 934f2da...6565f0c. Read the comment docs.

@maxnoe maxnoe marked this pull request as draft October 24, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants