Added attribute filter for skeleton points #9894
Open
+70
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
klakhov
reviewed
Nov 28, 2025
Comment on lines
+11
to
+29
| export const JobNotFoundComponent = React.memo((): JSX.Element => { | ||
| const history = useHistory(); | ||
| const handleGoToJobs = () => { | ||
| history.push('/jobs'); | ||
| }; | ||
| return ( | ||
| <Result | ||
| className='cvat-not-found' | ||
| status='404' | ||
| title='Sorry, but this job was not found' | ||
| subTitle='Please, be sure information you tried to get exist and you have access' | ||
| extra={ | ||
| <Button type='primary' onClick={handleGoToJobs}> | ||
| Go to Jobs (reset filters) | ||
| </Button> | ||
| } | ||
| /> | ||
| ); | ||
| }); |
Contributor
There was a problem hiding this comment.
This should be covered in #10028 with other not found components, I suggest to remove it
| }); | ||
|
|
||
| // If skeleton, add sublabel (point) attributes as nested fields | ||
| if (label.type === 'skeleton' && Array.isArray(label.sublabels)) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (label.type === 'skeleton' && Array.isArray(label.sublabels)) { | |
| if (label.type === 'skeleton' && Array.isArray(label.structure.sublabels)) { |
|
|
||
| // If skeleton, add sublabel (point) attributes as nested fields | ||
| if (label.type === 'skeleton' && Array.isArray(label.sublabels)) { | ||
| label.sublabels.forEach((sublabel: any) => { |
klakhov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.