fix: Geckodriver installation script version string comparison (#1447)

Author: MikeMcC399

factory/.env

@@ -18,7 +18,7 @@ NODE_VERSION="${FACTORY_DEFAULT_NODE_VERSION}"
 
 # Update the FACTORY_VERSION to deploy cypress/factory if you make changes to
 # BASE_IMAGE, FACTORY_DEFAULT_NODE_VERSION, YARN_VERSION, factory.Dockerfile or installScripts
-FACTORY_VERSION='7.0.1'
+FACTORY_VERSION='7.0.2'
 
 # Cypress officially supports the latest 3 major versions of Chrome, Firefox, and Edge only
 

factory/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change log
 
+## 7.0.2
+
+- Fixed Geckodriver installation script logic for Geckodriver versions > `0.99.x`. Addresses [#1444](https://github.com/cypress-io/cypress-docker-images/issues/1444).
+
 ## 7.0.1
 
 - Fixed Firefox installation script logic for Firefox versions > `999.x`. Addresses [#1443](https://github.com/cypress-io/cypress-docker-images/issues/1443).

factory/installScripts/geckodriver/install-geckodriver-version.js

@@ -10,10 +10,15 @@ if (!geckodriverVersion) {
 
 // See https://firefox-source-docs.mozilla.org/testing/geckodriver/Support.html for compatibility matrix
 // geckodriver < 0.34.0 only supports up to Firefox 120, which is no longer supported by Cypress
-const MIN_GECKO = '0.34.0'
-
-if (geckodriverVersion < MIN_GECKO) {
-  console.log(`geckodriver version ${geckodriverVersion} provided, minimum version ${MIN_GECKO} required, skipping geckodriver install`)
+const MINIMUM_GECKO_MAJOR = 0
+const MINIMUM_GECKO_MINOR = 34
+const geckodriverMajorVersion = geckodriverVersion.split('.').map(Number)[0]
+const geckodriverMinorVersion = geckodriverVersion.split('.').map(Number)[1]
+
+if (geckodriverMajorVersion < MINIMUM_GECKO_MAJOR
+  || (geckodriverMajorVersion === MINIMUM_GECKO_MAJOR && geckodriverMinorVersion < MINIMUM_GECKO_MINOR)
+) {
+  console.log(`geckodriver version ${geckodriverVersion} provided, minimum version ${MINIMUM_GECKO_MAJOR}.${MINIMUM_GECKO_MINOR}.x required, skipping geckodriver install`)
   process.exit(0)
 }