Commit 6f3b04c
authored
Don't write a cursor during the global DA => DA sensor migration for sensors that don't target any asset keys (#32794)
Summary:
Prevents an issue where:
- there is a large cursor
- we are migrating from global DA to sensors
- there is one or more sensors that don't actually target any assets
- the large cursor is written to that sensor
- the large cursor is never removed because the sensor never
executes/updates
Simulate a DA transition via script
Existing test coverage of the migration transition
## Summary & Motivation
## How I Tested These Changes
## Changelog
> Insert changelog entry or delete this section.1 parent 7f56fb3 commit 6f3b04c
File tree
2 files changed
+63
-13
lines changed- python_modules/dagster
- dagster_tests/declarative_automation_tests/daemon_tests
- dagster/_daemon
2 files changed
+63
-13
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
644 | 644 | | |
645 | 645 | | |
646 | 646 | | |
647 | | - | |
648 | | - | |
649 | 647 | | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
650 | 676 | | |
651 | 677 | | |
652 | 678 | | |
| |||
657 | 683 | | |
658 | 684 | | |
659 | 685 | | |
660 | | - | |
| 686 | + | |
661 | 687 | | |
662 | 688 | | |
663 | 689 | | |
| |||
Lines changed: 34 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
449 | 450 | | |
450 | 451 | | |
451 | 452 | | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
452 | 459 | | |
453 | 460 | | |
454 | 461 | | |
| |||
573 | 580 | | |
574 | 581 | | |
575 | 582 | | |
576 | | - | |
| 583 | + | |
577 | 584 | | |
578 | 585 | | |
579 | 586 | | |
| |||
594 | 601 | | |
595 | 602 | | |
596 | 603 | | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
597 | 613 | | |
598 | 614 | | |
599 | | - | |
600 | | - | |
601 | | - | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
602 | 619 | | |
603 | 620 | | |
604 | | - | |
605 | | - | |
606 | | - | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
607 | 631 | | |
608 | 632 | | |
609 | 633 | | |
| |||
737 | 761 | | |
738 | 762 | | |
739 | 763 | | |
740 | | - | |
| 764 | + | |
741 | 765 | | |
742 | 766 | | |
743 | 767 | | |
| |||
778 | 802 | | |
779 | 803 | | |
780 | 804 | | |
781 | | - | |
| 805 | + | |
782 | 806 | | |
783 | 807 | | |
784 | 808 | | |
| |||
809 | 833 | | |
810 | 834 | | |
811 | 835 | | |
812 | | - | |
| 836 | + | |
813 | 837 | | |
814 | 838 | | |
815 | 839 | | |
| |||
0 commit comments