Speed up or-ing many time window partition subsets together

[gibsondan]

Summary:
This is a bit of a micro-optimization, but I noticed that we were spending a bunch of time in the or operation here, and most of the time we should not need to or.

Test Plan: BK (which includes the multi-asset case)

Summary & Motivation

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

[OwenKephart]

I think it'd be a bit more elegant to update the __or__ method to take Union[Self, Sequence[Self]] and fork the behavior in there rather than to introduce a new name

[gibsondan]

I thought or was like a python built in

[graphite-app]

There appears to be a duplication issue in this code. The same partition subset is being added twice:

other_subset = asset_graph_subset.get_partitions_subset(asset_key)
if other_subset is not None:
    partition_subsets_by_asset_key[asset_key].append(other_subset)

partition_subsets_by_asset_key[asset_key].append(
    asset_graph_subset.get_partitions_subset(asset_key)
)

The second append is redundant since it's adding the same other_subset that was just conditionally added. This will cause duplicates in the list. The code should keep only the conditional append and remove the unconditional one.

Suggested change

	other_subset = asset_graph_subset.get_partitions_subset(asset_key)
	if other_subset is not None:
	partition_subsets_by_asset_key[asset_key].append(other_subset)
	partition_subsets_by_asset_key[asset_key].append(
	asset_graph_subset.get_partitions_subset(asset_key)
	)
	other_subset = asset_graph_subset.get_partitions_subset(asset_key)
	if other_subset is not None:
	partition_subsets_by_asset_key[asset_key].append(other_subset)

Spotted by Graphite Agent



Is this helpful? React 👍 or 👎 to let us know.