Skip to content

Commit c877ff9

Browse files
authored
Remove package:built_value dependency from HotReloadRequest (#2729)
* updated HotReloadRequest to use JSON serialization * merge main and rebuilt client.js * updated version to 26.2.4-wip
1 parent afd7acf commit c877ff9

File tree

9 files changed

+635
-848
lines changed

9 files changed

+635
-848
lines changed

dwds/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 26.2.4-wip
2+
3+
- Remove `package:built_value` dependency from `HotReloadRequest` and use standard Dart JSON serialization instead.
4+
15
## 26.2.3
26

37
- Bump `build_web_compilers` to ^4.4.1.

dwds/lib/data/hot_reload_request.dart

Lines changed: 20 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,28 @@
44

55
library hot_reload_request;
66

7-
import 'package:built_value/built_value.dart';
8-
import 'package:built_value/serializer.dart';
7+
/// A request to hot reload the application.
8+
class HotReloadRequest {
9+
/// A unique identifier for this request.
10+
final String id;
911

10-
part 'hot_reload_request.g.dart';
12+
HotReloadRequest({required this.id});
1113

12-
/// A request to hot reload the application.
13-
abstract class HotReloadRequest
14-
implements Built<HotReloadRequest, HotReloadRequestBuilder> {
15-
static Serializer<HotReloadRequest> get serializer =>
16-
_$hotReloadRequestSerializer;
14+
/// Creates a [HotReloadRequest] from a JSON map.
15+
factory HotReloadRequest.fromJson(Map<String, dynamic> json) {
16+
return HotReloadRequest(id: json['id'] as String);
17+
}
1718

18-
/// A unique identifier for this request.
19-
String get id;
19+
/// Converts this [HotReloadRequest] to a JSON map.
20+
Map<String, dynamic> toJson() => {'id': id};
21+
22+
@override
23+
bool operator ==(Object other) =>
24+
identical(other, this) || other is HotReloadRequest && id == other.id;
25+
26+
@override
27+
int get hashCode => id.hashCode;
2028

21-
HotReloadRequest._();
22-
factory HotReloadRequest([void Function(HotReloadRequestBuilder) updates]) =
23-
_$HotReloadRequest;
29+
@override
30+
String toString() => 'HotReloadRequest(id: $id)';
2431
}

dwds/lib/data/hot_reload_request.g.dart

Lines changed: 0 additions & 148 deletions
This file was deleted.

dwds/lib/data/serializers.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import 'debug_info.dart';
1212
import 'devtools_request.dart';
1313
import 'error_response.dart';
1414
import 'extension_request.dart';
15-
import 'hot_reload_request.dart';
1615
import 'hot_reload_response.dart';
1716
import 'hot_restart_request.dart';
1817
import 'hot_restart_response.dart';
@@ -34,7 +33,6 @@ part 'serializers.g.dart';
3433
DebugInfo,
3534
DevToolsRequest,
3635
DevToolsResponse,
37-
HotReloadRequest,
3836
HotReloadResponse,
3937
HotRestartRequest,
4038
HotRestartResponse,

dwds/lib/data/serializers.g.dart

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)