Skip to content

Commit 938197d

Browse files
committed
tests: avoid Raycast segfault when no hits
1 parent cc666ca commit 938197d

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

tests/integration/test_Raycast.cpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,8 @@ void testBasicInterface(const std::shared_ptr<CollisionDetector>& cd)
102102
Eigen::Vector3d(2, 0, 0),
103103
option,
104104
&result);
105-
EXPECT_TRUE(result.hasHit());
106-
EXPECT_EQ(result.mRayHits.size(), 1u);
105+
ASSERT_TRUE(result.hasHit());
106+
ASSERT_EQ(result.mRayHits.size(), 1u);
107107
rayHit = result.mRayHits[0];
108108
EXPECT_TRUE(equals(rayHit.mPoint, Eigen::Vector3d(-1, 0, 0)));
109109
EXPECT_TRUE(equals(rayHit.mNormal, Eigen::Vector3d(-1, 0, 0)));
@@ -118,8 +118,8 @@ void testBasicInterface(const std::shared_ptr<CollisionDetector>& cd)
118118
Eigen::Vector3d(-2, 0, 0),
119119
option,
120120
&result);
121-
EXPECT_TRUE(result.hasHit());
122-
EXPECT_EQ(result.mRayHits.size(), 1u);
121+
ASSERT_TRUE(result.hasHit());
122+
ASSERT_EQ(result.mRayHits.size(), 1u);
123123
rayHit = result.mRayHits[0];
124124
EXPECT_TRUE(equals(rayHit.mPoint, Eigen::Vector3d(1, 0, 0)));
125125
EXPECT_TRUE(equals(rayHit.mNormal, Eigen::Vector3d(1, 0, 0)));
@@ -133,8 +133,8 @@ void testBasicInterface(const std::shared_ptr<CollisionDetector>& cd)
133133
Eigen::Vector3d(2, 0, 0),
134134
option,
135135
&result);
136-
EXPECT_TRUE(result.hasHit());
137-
EXPECT_EQ(result.mRayHits.size(), 1u);
136+
ASSERT_TRUE(result.hasHit());
137+
ASSERT_EQ(result.mRayHits.size(), 1u);
138138
rayHit = result.mRayHits[0];
139139
EXPECT_TRUE(equals(rayHit.mPoint, Eigen::Vector3d(0, 0, 0)));
140140
EXPECT_TRUE(equals(rayHit.mNormal, Eigen::Vector3d(-1, 0, 0)));
@@ -194,8 +194,8 @@ void testOptions(const std::shared_ptr<CollisionDetector>& cd)
194194
Eigen::Vector3d(5, 0, 0),
195195
option,
196196
&result);
197-
EXPECT_TRUE(result.hasHit());
198-
EXPECT_EQ(result.mRayHits.size(), 1u);
197+
ASSERT_TRUE(result.hasHit());
198+
ASSERT_EQ(result.mRayHits.size(), 1u);
199199
rayHit = result.mRayHits[0];
200200
EXPECT_TRUE(equals(rayHit.mPoint, Eigen::Vector3d(-3, 0, 0)));
201201
EXPECT_TRUE(equals(rayHit.mNormal, Eigen::Vector3d(-1, 0, 0)));
@@ -212,8 +212,8 @@ void testOptions(const std::shared_ptr<CollisionDetector>& cd)
212212
Eigen::Vector3d(5, 0, 0),
213213
option,
214214
&result);
215-
EXPECT_TRUE(result.hasHit());
216-
EXPECT_EQ(result.mRayHits.size(), 2u);
215+
ASSERT_TRUE(result.hasHit());
216+
ASSERT_EQ(result.mRayHits.size(), 2u);
217217
rayHit = result.mRayHits[0];
218218
EXPECT_TRUE(equals(rayHit.mPoint, Eigen::Vector3d(-3, 0, 0)));
219219
EXPECT_TRUE(equals(rayHit.mNormal, Eigen::Vector3d(-1, 0, 0)));

0 commit comments

Comments
 (0)