test: feature_llmq_signing.py --spork21 intermittent timeout in wait_for_sigs

[thepastaclaw]

Summary

feature_llmq_signing.py --spork21 intermittently fails with a wait_until() timeout in wait_for_sigs(). The failure is timing-dependent and not reproducible — the same test passes on develop and the non---spork21 variant passes consistently on the same CI run.

Failure Details

Test: feature_llmq_signing.py --spork21
Error: AssertionError: Predicate '' not true after N seconds
Location: feature_llmq_signing.py:111 → wait_for_sigs(True, False, True, 15) (15s timeout)
Traceback:

File "feature_llmq_signing.py", line 111, in run_test
    wait_for_sigs(True, False, True, 15)
File "feature_llmq_signing.py", line 60, in wait_for_sigs
    self.wait_until(lambda: check_sigs(hasrecsigs, isconflicting1, isconflicting2), timeout = timeout)
AssertionError: Predicate '' not true after <timeout> seconds

Retry behavior: Failed all 3 CI retry attempts (attempt 1: 128s, attempt 2: 114s, attempt 3: 131s)

CI Log Links

• Failing run on PR fix: register shareman recovery interface in ActiveContext #7244: https://github.com/dashpay/dash/actions/runs/23441584574/job/68207659502
• Passing run on develop (same commit after merge): https://github.com/dashpay/dash/actions/runs/23505322590 — linux64_multiprocess-test / Test source passed

Evidence of Flakiness

1. The non---spork21 variant (feature_llmq_signing.py) passed on the exact same CI run
2. The --spork21 variant passed on develop after the PR was merged (CI run 23505322590)
3. PR fix: register shareman recovery interface in ActiveContext #7244 only modifies src/active/context.cpp (adds shareman->RegisterRecoveryInterface()) — no test files or LLMQ signing logic changed

Root Cause Analysis

The 15-second timeout in wait_for_sigs() appears insufficient for the multiprocess test environment under CI load. The --spork21 variant likely exercises a slightly different code path that takes marginally longer, hitting the timeout under resource contention.

Suggested Fix

Consider increasing the timeout in wait_for_sigs() calls within the --spork21 path, or using self.options.timeout_factor to scale timeouts appropriately for CI environments.

[thepastaclaw]

Another occurrence of this flaky test failure:

CI run: https://github.com/dashpay/dash/actions/runs/23780028947/job/69294959989
PR: #7251 (ci: convert clang-format diff check to informational PR comment — only changes .github/workflows/clang-diff-format.yml)
Build target: linux64_multiprocess
Date: 2026-03-31

The test failed 3/3 attempts with the same wait_until() timeout:

AssertionError: Predicate '' not true after N seconds

Other LLMQ tests also failed on first attempt during this run (feature_llmq_data_recovery, feature_llmq_simplepose, feature_llmq_dkgerrors) but passed on retry — suggesting general LLMQ test instability on ARM runners.

[thepastaclaw]

Another occurrence from PR #7242 (wallet deprecation + RPC type checking backport), but this one is unrelated to the PR changes.

• CI run: https://github.com/dashpay/dash/actions/runs/24064815059/job/70192274452
• Build target: linux64_multiprocess
• Date: 2026-04-07

The failure was again feature_llmq_signing.py --spork21, timing out in wait_for_sigs(True, False, True, 15) after retrying 3/3 times:

AssertionError: Predicate "" not true after 60.0 seconds

Same run also had separate in-scope addressindex RPC type-check failures in other jobs; those were fixed on the PR branch independently. This multiprocess failure still looks like the existing intermittent LLMQ signing flake.

[thepastaclaw]

Another occurrence from PR #7232, again unrelated to the PR diff itself (the PR only changes CI/workflow/env files plus test/get_previous_releases.py).

• CI run: https://github.com/dashpay/dash/actions/runs/24081094106
• Job: linux64-test / Test source (70248433408)
• Date: 2026-04-07

This run hit the same feature_llmq_signing.py DKG phase timeout in wait_for_quorum_phase():

AssertionError: Predicate ... not true after 120.0 seconds

Same job also had separate collateral failures from a missing shared RPC coverage temp dir (dashpay/dash#7273), but the LLMQ signing timeout is still the existing intermittent failure tracked here.