Removed the dead code in _join() (#630)

* Add unit tests for join method coverage

* Removed proposed test cases and the dead code in _join()

Author: joshu4lim

datascience/tables.py

@@ -2036,11 +2036,6 @@ def join(self, column_label, other, other_label=None):
 
     def _join(self, column_label, other, other_label=[]):
         """joins when COLUMN_LABEL is a string"""
-        if self.num_rows == 0 or other.num_rows == 0:
-            return None
-        if not other_label:
-            other_label = column_label
-
         self_rows = self.index_by(column_label)
         other_rows = other.index_by(other_label)
         return self._join_helper([column_label], self_rows, other, [other_label], other_rows)

tests/test_tables.py

@@ -1659,8 +1659,8 @@ def test_join_without_other_label(table, table2):
     2      | b      | 3     | two
     2      | c      | 3     | two
     """)
-
-
+    
+    
 ##################
 # Export/Display #
 ##################