refactor(appkit): let the framework own ai-search missing-resource policy

setup()'s indexName-presence check duplicated the framework's resource
validation, which already warns-in-dev / throws-in-prod for a missing
DATABRICKS_VS_INDEX_NAME and runs before setup(). The inline NODE_ENV gate
was therefore redundant, its prod-throw branch was unreachable in the real
createApp flow, and it silently ignored APPKIT_STRICT_VALIDATION (which the
registry honors). Drop it and keep only the pagination -> endpointName check,
a config logic error the registry can't see. Unresolved aliases still 404 on
the routes and throw in query(). Removes the two now-obsolete setup() tests.

Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>

Author: MarioCadenas

packages/appkit/src/plugins/ai-search/ai-search.ts

@@ -44,20 +44,11 @@ export class AiSearchPlugin extends Plugin<IAiSearchConfig> {
   }
 
   async setup(): Promise<void> {
-    const isDev = process.env.NODE_ENV === "development";
+    // A missing indexName is a missing-resource condition owned by the
+    // framework's resource validation (warn in dev, throw in prod). Only the
+    // pagination -> endpointName dependency is a config logic error the
+    // framework can't see, so it's the sole check here.
     for (const [alias, idx] of Object.entries(this.config.indexes ?? {})) {
-      // A missing indexName is a missing-resource condition, which the
-      // framework's resource validation already reports (warn in dev, throw
-      // in prod). Mirror that policy here instead of hard-crashing dev.
-      if (!this._resolveIndex(alias)) {
-        const message = `Index "${alias}" has no indexName (set it in config or via DATABRICKS_VS_INDEX_NAME)`;
-        if (isDev) {
-          logger.warn(message);
-          continue;
-        }
-        throw new Error(message);
-      }
-      // A config logic error, not a missing resource — always fail fast.
       if (idx.pagination && !idx.endpointName) {
         throw new Error(
           `Index "${alias}" has pagination enabled but is missing "endpointName"`,

packages/appkit/src/plugins/ai-search/tests/ai-search.test.ts

@@ -111,36 +111,12 @@ describe("AiSearchPlugin", () => {
 
   describe("setup()", () => {
     const originalIndexEnv = process.env.DATABRICKS_VS_INDEX_NAME;
-    const originalNodeEnv = process.env.NODE_ENV;
     afterEach(() => {
       if (originalIndexEnv === undefined) {
         delete process.env.DATABRICKS_VS_INDEX_NAME;
       } else {
         process.env.DATABRICKS_VS_INDEX_NAME = originalIndexEnv;
       }
-      process.env.NODE_ENV = originalNodeEnv;
-    });
-
-    it("throws outside dev if indexName is unset in both config and env", async () => {
-      delete process.env.DATABRICKS_VS_INDEX_NAME;
-      process.env.NODE_ENV = "production";
-      const plugin = new AiSearchPlugin({
-        indexes: {
-          test: { columns: ["id"] },
-        },
-      });
-      await expect(plugin.setup()).rejects.toThrow("indexName");
-    });
-
-    it("only warns (does not throw) for a missing indexName in dev", async () => {
-      delete process.env.DATABRICKS_VS_INDEX_NAME;
-      process.env.NODE_ENV = "development";
-      const plugin = new AiSearchPlugin({
-        indexes: {
-          test: { columns: ["id"] },
-        },
-      });
-      await expect(plugin.setup()).resolves.not.toThrow();
     });
 
     it("defaults indexName from DATABRICKS_VS_INDEX_NAME when omitted", async () => {