fix: language server diagnostics return empty list instead of null

mitsaucepls · daveshanley · commit e98c328e6b66 · 2025-10-22T10:55:44.000-04:00
diff --git a/language-server/server.go b/language-server/server.go
@@ -47,7 +47,7 @@ func NewServer(version string, lintRequest *utils.LintFileRequest) *ServerState
 		lintRequest:   lintRequest,
 		documentStore: newDocumentStore(),
 	}
-	handler.Initialize = func(context *glsp.Context, params *protocol.InitializeParams) (interface{}, error) {
+	handler.Initialize = func(context *glsp.Context, params *protocol.InitializeParams) (any, error) {
 		if params.Trace != nil {
 			protocol.SetTraceValue(*params.Trace)
 		}
@@ -153,7 +153,7 @@ func (s *ServerState) runDiagnostic(doc *Document, notify glsp.NotifyFunc) {
 }
 
 func ConvertResultsIntoDiagnostics(result *motor.RuleSetExecutionResult) []protocol.Diagnostic {
-	var diagnostics []protocol.Diagnostic
+	diagnostics := []protocol.Diagnostic{}
 
 	for _, vacuumResult := range result.Results {
 		diagnostics = append(diagnostics, ConvertResultIntoDiagnostic(&vacuumResult))

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ func NewServer(version string, lintRequest utils.LintFileRequest) ServerState`
`47`	`47`	`lintRequest: lintRequest,`
`48`	`48`	`documentStore: newDocumentStore(),`
`49`	`49`	`}`
`50`		`- handler.Initialize = func(context glsp.Context, params protocol.InitializeParams) (interface{}, error) {`
	`50`	`+ handler.Initialize = func(context glsp.Context, params protocol.InitializeParams) (any, error) {`
`51`	`51`	`if params.Trace != nil {`
`52`	`52`	`protocol.SetTraceValue(*params.Trace)`
`53`	`53`	`}`
`@@ -153,7 +153,7 @@ func (s ServerState) runDiagnostic(doc Document, notify glsp.NotifyFunc) {`
`153`	`153`	`}`
`154`	`154`
`155`	`155`	`func ConvertResultsIntoDiagnostics(result *motor.RuleSetExecutionResult) []protocol.Diagnostic {`
`156`		`- var diagnostics []protocol.Diagnostic`
	`156`	`+ diagnostics := []protocol.Diagnostic{}`
`157`	`157`
`158`	`158`	`for _, vacuumResult := range result.Results {`
`159`	`159`	`diagnostics = append(diagnostics, ConvertResultIntoDiagnostic(&vacuumResult))`