Repository navigation
Commit 18f469c
committed
Document the still-needed xfail on the multi-column sub-select test
dbaty asked whether the xfail on test_sub_select_multiple_col_name_completion
(added in 4e86201 in 2015, without explanation) is still needed. It is:
removing the marker makes the test fail on sqlparse 0.6.0. Parsing the
incomplete 'SELECT a, FROM abc' still treats the token before the trailing
comma ('a') as a table, so the Column suggestion carries table_refs for both
'a' and 'abc' instead of just 'abc'.
Keep the marker but give it a reason so the 2015 gap dbaty flagged is closed:
future readers see why the failure is expected instead of an undocumented
decorator.1 parent 0821f4b commit 18f469c
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
450 | 450 | | |
451 | 451 | | |
452 | 452 | | |
453 | | - | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
454 | 459 | | |
455 | 460 | | |
456 | 461 | | |
| |||
0 commit comments