Rename test methods for better readability.

deanagan · deanagan · commit cc1106fc1fd4 · 2020-01-27T12:17:52.000+11:00
diff --git a/strategy_pattern/strategy_pattern_test/strategy_test.cs b/strategy_pattern/strategy_pattern_test/strategy_test.cs
@@ -34,7 +34,7 @@ public void Setup()
         }
 
         [Test]
-        public void TestGetDiscountIfMemberCouponValidRegularItem_ShouldReturnMemberDiscountedPrice()
+        public void DiscountIfMember_WithValidCoupon_ForRegularItem_ShouldReturnMemberDiscountedPrice()
         {
             // Arrange
             _mockCoupon = CreateMockCoupon(false, 5);
@@ -48,7 +48,7 @@ public void TestGetDiscountIfMemberCouponValidRegularItem_ShouldReturnMemberDisc
         }
 
         [Test]
-        public void TestGetDiscountIfNonMemberCouponValidRegularItem_ShouldReturnNonMemberDiscountedPrice()
+        public void DiscountIfNonMember_WithValidCoupon_ForRegularItem_ShouldReturnNonMemberDiscountedPrice()
         {
             // Arrange
            _mockCoupon = CreateMockCoupon(false, 5);
@@ -62,7 +62,7 @@ public void TestGetDiscountIfNonMemberCouponValidRegularItem_ShouldReturnNonMemb
         }
 
         [Test]
-        public void TestGetDiscountIfMemberCouponExpired_ShouldReturnNoCouponDiscountedPrice()
+        public void DiscountIfMember_WithCouponExpired_ShouldReturnBaseMemberDiscountOnly()
         {
             // Arrange
             _mockCoupon = CreateMockCoupon(true, 5);
@@ -76,7 +76,7 @@ public void TestGetDiscountIfMemberCouponExpired_ShouldReturnNoCouponDiscountedP
         }
 
         [Test]
-        public void TestGetDiscountIfNonMemberCouponExpired_ShouldReturnNoNonMemberDiscountedPrice()
+        public void DiscountIfNonMember_WithCouponExpired_ShouldReturnNoDiscount()
         {
             // Arrange
             _mockCoupon = CreateMockCoupon(true, 5);
@@ -90,7 +90,7 @@ public void TestGetDiscountIfNonMemberCouponExpired_ShouldReturnNoNonMemberDisco
         }
 
         [Test]
-        public void TestGetDiscountIfMemberCouponValidOnProductAlreadyOnSale_ShouldReturnBaseMemberDiscountedAddedToSalePrice()
+        public void DiscountIfMember_WithValidCoupon_ForProductAlreadyOnSale_ShouldReturnBaseMemberDiscountedAddedToSalePrice()
         {
             // Arrange
             _mockCoupon = CreateMockCoupon(false, 5);
@@ -104,7 +104,7 @@ public void TestGetDiscountIfMemberCouponValidOnProductAlreadyOnSale_ShouldRetur
         }
 
         [Test]
-        public void TestGetDiscountIfNonMemberCouponValidOnProductAlreadyOnSale_ShouldReturnSalePrice()
+        public void DiscountIfNonMember_WithValidCoupon_ForProductAlreadyOnSale_ShouldReturnSalePriceOnly()
         {
             // Arrange
             _mockCoupon = CreateMockCoupon(false, 5);

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public void Setup()`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`[Test]`
`37`		`- public void TestGetDiscountIfMemberCouponValidRegularItem_ShouldReturnMemberDiscountedPrice()`
	`37`	`+ public void DiscountIfMember_WithValidCoupon_ForRegularItem_ShouldReturnMemberDiscountedPrice()`
`38`	`38`	`{`
`39`	`39`	`// Arrange`
`40`	`40`	`_mockCoupon = CreateMockCoupon(false, 5);`
`@@ -48,7 +48,7 @@ public void TestGetDiscountIfMemberCouponValidRegularItem_ShouldReturnMemberDisc`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`[Test]`
`51`		`- public void TestGetDiscountIfNonMemberCouponValidRegularItem_ShouldReturnNonMemberDiscountedPrice()`
	`51`	`+ public void DiscountIfNonMember_WithValidCoupon_ForRegularItem_ShouldReturnNonMemberDiscountedPrice()`
`52`	`52`	`{`
`53`	`53`	`// Arrange`
`54`	`54`	`_mockCoupon = CreateMockCoupon(false, 5);`
`@@ -62,7 +62,7 @@ public void TestGetDiscountIfNonMemberCouponValidRegularItem_ShouldReturnNonMemb`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`[Test]`
`65`		`- public void TestGetDiscountIfMemberCouponExpired_ShouldReturnNoCouponDiscountedPrice()`
	`65`	`+ public void DiscountIfMember_WithCouponExpired_ShouldReturnBaseMemberDiscountOnly()`
`66`	`66`	`{`
`67`	`67`	`// Arrange`
`68`	`68`	`_mockCoupon = CreateMockCoupon(true, 5);`
`@@ -76,7 +76,7 @@ public void TestGetDiscountIfMemberCouponExpired_ShouldReturnNoCouponDiscountedP`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`[Test]`
`79`		`- public void TestGetDiscountIfNonMemberCouponExpired_ShouldReturnNoNonMemberDiscountedPrice()`
	`79`	`+ public void DiscountIfNonMember_WithCouponExpired_ShouldReturnNoDiscount()`
`80`	`80`	`{`
`81`	`81`	`// Arrange`
`82`	`82`	`_mockCoupon = CreateMockCoupon(true, 5);`
`@@ -90,7 +90,7 @@ public void TestGetDiscountIfNonMemberCouponExpired_ShouldReturnNoNonMemberDisco`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`[Test]`
`93`		`- public void TestGetDiscountIfMemberCouponValidOnProductAlreadyOnSale_ShouldReturnBaseMemberDiscountedAddedToSalePrice()`
	`93`	`+ public void DiscountIfMember_WithValidCoupon_ForProductAlreadyOnSale_ShouldReturnBaseMemberDiscountedAddedToSalePrice()`
`94`	`94`	`{`
`95`	`95`	`// Arrange`
`96`	`96`	`_mockCoupon = CreateMockCoupon(false, 5);`
`@@ -104,7 +104,7 @@ public void TestGetDiscountIfMemberCouponValidOnProductAlreadyOnSale_ShouldRetur`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`[Test]`
`107`		`- public void TestGetDiscountIfNonMemberCouponValidOnProductAlreadyOnSale_ShouldReturnSalePrice()`
	`107`	`+ public void DiscountIfNonMember_WithValidCoupon_ForProductAlreadyOnSale_ShouldReturnSalePriceOnly()`
`108`	`108`	`{`
`109`	`109`	`// Arrange`
`110`	`110`	`_mockCoupon = CreateMockCoupon(false, 5);`