fix(check): do not error for unsupported URL schemes (#30904)

Closes #30898

Author: dsherret

libs/resolver/file_fetcher.rs

@@ -629,6 +629,17 @@ impl<
       }
     }
 
+    if !matches!(
+      specifier.scheme(),
+      "file" | "http" | "https" | "blob" | "data"
+    ) {
+      return Box::pin(std::future::ready(Ok(Some(
+        deno_graph::source::LoadResponse::External {
+          specifier: specifier.clone(),
+        },
+      ))));
+    }
+
     self.load_or_cache(
       LoadStrategy {
         file_fetcher: self.file_fetcher.clone(),

libs/resolver/loader/module_loader.rs

@@ -94,6 +94,20 @@ pub enum LoadCodeSourceErrorKind {
   #[class(inherit)]
   #[error(transparent)]
   PathToUrl(#[from] deno_path_util::PathToUrlError),
+  #[class(inherit)]
+  #[error(transparent)]
+  UnsupportedScheme(#[from] UnsupportedSchemeError),
+}
+
+// this message list additional `npm` and `jsr` schemes, but they should actually be handled
+// before these APIs are even hit.
+#[derive(Debug, thiserror::Error, deno_error::JsError)]
+#[class(type)]
+#[error(
+  "Unsupported scheme \"{}\" for module \"{}\". Supported schemes:\n - \"blob\"\n - \"data\"\n - \"file\"\n - \"http\"\n - \"https\"\n - \"jsr\"\n - \"npm\"", url.scheme(), url
+)]
+pub struct UnsupportedSchemeError {
+  pub url: Url,
 }
 
 #[derive(Debug, thiserror::Error, deno_error::JsError)]
@@ -188,7 +202,17 @@ impl<TSys: ModuleLoaderSys> ModuleLoader<TSys> {
     {
       Some(module_or_asset) => module_or_asset,
       None => {
-        if self.in_npm_pkg_checker.in_npm_package(specifier) {
+        if !matches!(
+          specifier.scheme(),
+          "https" | "http" | "file" | "blob" | "data"
+        ) {
+          return Err(
+            UnsupportedSchemeError {
+              url: specifier.clone(),
+            }
+            .into(),
+          );
+        } else if self.in_npm_pkg_checker.in_npm_package(specifier) {
           let loaded_module = self
             .npm_module_loader
             .load(

tests/specs/check/special_specifiers/__test__.jsonc

@@ -0,0 +1,4 @@
+{
+  "args": "check",
+  "output": "check.out"
+}

tests/specs/check/special_specifiers/check.out

@@ -0,0 +1 @@
+Check file:///[WILDCARD]/mod.ts

tests/specs/check/special_specifiers/deno.json

@@ -0,0 +1,5 @@
+{
+  "compilerOptions": {
+    "types": ["@types/cloudflare"]
+  }
+}

tests/specs/check/special_specifiers/mod.ts

@@ -0,0 +1,2 @@
+declare module "cloudflare:sockets" {
+}

tests/specs/check/special_specifiers/node_modules/@types/cloudflare/index.d.ts

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "@types/cloudflare": "*"
+  }
+}

tests/specs/check/special_specifiers/node_modules/@types/cloudflare/package.json

@@ -1,9 +1 @@
-error: Unsupported scheme "ext" for module "ext:runtime/01_errors.js". Supported schemes:
- - "blob"
- - "data"
- - "file"
- - "http"
- - "https"
- - "jsr"
- - "npm"
-    at [WILDCARD]/extension_import.ts:1:8
+error: Importing ext: modules is only allowed from ext: and node: modules. Tried to import ext:runtime/01_errors.js from file:///[WILDLINE]/extension_import.ts