`url.domainToASCII` cannot handle invalid domains

[davidebombelli]

Summary

url.domainToASCII should print an empty string when an invalid domain is passed.

Version

deno 2.5.4 (stable, release, x86_64-unknown-linux-gnu)

v8 14.0.365.5-rusty

typescript 5.9.2

OS

Linux Mint 22 Wilma

Steps to reproduce

1. Create file test.mjs with the following content:

import url from 'node:url';

console.log(url.domainToASCII('xn--iñvalid.com'));

2. Run file deno test.mjs.

Expected Behaviour

An empty string should be output.

Actual Behaviour

error: Uncaught (in promise) Error: Errors
    at domainToASCII (ext:deno_node/internal/idna.ts:95:10)
    at Object.domainToASCII (node:url:1136:10)

[denobot]

I've created a PR to fix this issue: #31219

Summary of Changes

The fix modifies url.domainToASCII to return an empty string when an invalid domain is passed (matching Node.js behavior), instead of throwing an error.

Changes Made:

• Modified op_node_idna_domain_to_ascii in ext/node/ops/idna.rs to catch errors and return an empty string using .unwrap_or_default()
• Updated documentation to clarify this behavior
• Added comprehensive spec tests to verify the fix

Testing:

The fix has been tested with the example from the issue:

import url from 'node:url';
console.log(url.domainToASCII('xn--iñvalid.com')); // Now returns "" instead of throwing

And verified to match Node.js behavior for both valid and invalid domains.

---

This PR was autogenerated and may require review and adjustments.