feat(permissions): allow flags should override deny when more specific #31224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]> Signed-off-by: David Sherret <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the permission system to improve handling of granular allow and deny rules. The main change replaces separate HashSet-based storage for granted, flag-denied, and prompt-denied descriptors with a unified sorted vector-based approach, enabling more precise permission resolution with partial denials.
- Changed data structure from
HashSet-based to sortedVec-based descriptor storage - Added
DeniedPartialstate to distinguish between full and partial denials - Implemented comparison traits for descriptor ordering to support binary search
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| runtime/permissions/lib.rs | Core refactoring: unified descriptor storage, added sorting/comparison logic, implemented partial denial handling |
| runtime/permissions/Cargo.toml | Added test features for sys_traits dependency |
| runtime/ops/permissions.rs | Updated PermissionStatus to use static string for state and handle DeniedPartial |
| libs/config/deno_json/permissions.rs | Added helper method and simplified empty check logic |
| cli/args/mod.rs | Renamed variable from no_op to identity for clarity |
| Cargo.toml | Updated fqdn dependency from 0.3.4 to 0.4.6 |
| Cargo.lock | Updated fqdn package checksum and version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dsherret
commented
Nov 7, 2025
| state.to_string() | ||
| state: match state { | ||
| PermissionState::Granted | PermissionState::GrantedPartial => "granted", | ||
| PermissionState::DeniedPartial | PermissionState::Denied => "denied", |
Member
Author
There was a problem hiding this comment.
This DeniedPartial isn't used at the moment, but it's useful granularity to have. I'll use it in a future PR that I extract out of #31187
Co-authored-by: Copilot <[email protected]> Signed-off-by: David Sherret <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow flags that are more specific than deny flags should take precedence.
Some examples:
--allow-read=./data/sub --deny-read=./data--allow-env=NODE_ENV --deny-read=NODE_*Extracted out of #31187 -- This behaviour will be more important when the
--ingore-envflag is added in order to make the feature more powerful.