Skip to content

fix(ext/node): ensure 'exit' event is fired only once for worker_threads #31231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 12, 2025
Merged

fix(ext/node): ensure 'exit' event is fired only once for worker_threads #31231

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c650d9e
fix(node:worker_threads): ensure 'exit' event fires once and matches …
TarikSogukpinar Nov 8, 2025
d25167f
chore(node:worker_threads): fix indentation and remove misleading fal…
TarikSogukpinar Nov 8, 2025
fad5dcd
fix(node:worker_threads): ensure exit event emitted on terminate()
TarikSogukpinar Nov 8, 2025
e524880
style(node:worker_threads): fix indentation in terminate()
TarikSogukpinar Nov 8, 2025
a266300
test(node:worker_threads): add tests for worker termination and onlin…
TarikSogukpinar Nov 10, 2025
830ebb1
Merge branch 'main' into fix/node-workers-exit-event
TarikSogukpinar Nov 10, 2025
44c500b
style(node:worker_threads): improve formatting of test name for onlin…
TarikSogukpinar Nov 10, 2025
e8341c9
Merge remote-tracking branch 'origin/fix/node-workers-exit-event' int…
TarikSogukpinar Nov 10, 2025
e7700b4
Merge branch 'main' into fix/node-workers-exit-event
TarikSogukpinar Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ext/node/polyfills/worker_threads.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ class NodeWorker extends EventEmitter {
#messagePromise = undefined;
#controlPromise = undefined;
#workerOnline = false;
#exited = false;
// "RUNNING" | "CLOSED" | "TERMINATED"
// "TERMINATED" means that any controls or messages received will be
// discarded. "CLOSED" means that we have received a control
Expand Down Expand Up @@ -229,6 +230,11 @@ class NodeWorker extends EventEmitter {
switch (type) {
case 1: { // TerminalError
this.#status = "CLOSED";
if (!this.#exited) {
this.#exited = true;
this.emit("exit", 1);
}
return;
} /* falls through */
case 2: { // Error
this.#handleError(data);
Expand All @@ -237,6 +243,10 @@ class NodeWorker extends EventEmitter {
case 3: { // Close
debugWT(`Host got "close" message from worker: ${this.#name}`);
this.#status = "CLOSED";
if (!this.#exited) {
this.#exited = true;
this.emit("exit", 0);
}
return;
}
default: {
Expand Down Expand Up @@ -314,7 +324,6 @@ class NodeWorker extends EventEmitter {
if (this.#status !== "TERMINATED") {
this.#status = "TERMINATED";
op_host_terminate_worker(this.#id);
this.emit("exit", 0);
}
return PromiseResolve(0);
}
Expand Down
Loading