Extend auto detection of bin/php

[kszymukowicz]

hi,

what you think of extending a bin/php auto detection?

Current default implementation IMHO serves only small percent of use cases and therefore must be anyway set manually.

The example implementation above works like that:

1. It takes as first php_version if it is set explicitly for host.
2. If php_version is not set for host then composer.json file is searched for ['config']['platform']['php'] and if not found then for ['require']['php'].
3. Values set from point 1 or point 2 are then normalised to 'X.Y' and system is checked for specific PHP binaries with which('phpX.Y') and which('phpXY').
4. If none of php_version, ['config']['platform']['php'], ['require']['php'] are set then there is standard check for which('php').

set('bin/php', function () {
    if (currentHost()->hasOwn('php_version')) {
        $rawPhpVersion = get('php_version');
    }

    if (empty($rawPhpVersion) && file_exists('composer.json')) {
        $composerJson = json_decode(file_get_contents('composer.json'), true);
        if (isset($composerJson['config']['platform']['php'])) {
            $rawPhpVersion = $composerJson['config']['platform']['php'];
        }
        if (empty($rawPhpVersion) && isset($composerJson['require']['php'])) {
            $rawPhpVersion = $composerJson['require']['php'];
        }
    }

    $phpVersionMajorMinor = null;
    if (!empty($rawPhpVersion) && preg_match('/[^0-9]*(\d+)(?:\.(\d+))?(?:\.\d+)?/', $rawPhpVersion, $matches)) {
        if (isset($matches[1]) && is_numeric($matches[1])) {
            $phpVersionMajorMinor = $matches[1] . (isset($matches[2]) && is_numeric($matches[2]) ? '.' . $matches[2] : '.0');
        }
    }

    if ($phpVersionMajorMinor) {
        try {
            return which('php' . $phpVersionMajorMinor);
        } catch (\Throwable $e) {
            return which('php' . str_replace('.', '', $phpVersionMajorMinor));
        }
    }

    return which('php');
});

[antonmedv]

But what problem does it solve?
it looks like it will be much more complicated and difficult to understand.

Right now, you can simply overwrite bin/php per host with desired value

[kszymukowicz]

The proposed solution solves IMO following issues:

1. Eliminates manual configuration
   No need to set php_version or bin/php at all, for 99% of cases.

2. Reduces maintenance overhead
   If bin/php can be removed and php bin resolved based on composer.json automatically, then developer does not need to remember about php configuration of hosts at all.

3. Addresses binary naming differences
   The current implementation uses a fixed format (return '/usr/bin/php{{php_version}}') which fails on systems with different PHP binary naming conventions. Some systems use /user/bin/php82 and some /user/bin/php8.2, not ot mention some which put php binaries in different folders. The proposed solution is looking for specific PHP version with which and with both formats (with and without dot) sequentially, ensuring compatibility across various systems.

[antonmedv]

Another thing which is not to be very general is using local file:

    $composerJson = json_decode(file_get_contents('composer.json'), true);

In case there is no local files, it can be a problem.

[kszymukowicz]

In case user is removing composer.json then he must use php_version setting then.