Skip to content

client.kubernetes.create_cluster does not implement registry_enabled as advertised #433

@reinvantveer

Description

@reinvantveer

It appears that 0.10.0 (and earlier) does not correctly pick up the registry_enabled flag as documented in https://pydo.readthedocs.io/en/latest/pydo.aio.operations.html#pydo.aio.operations.KubernetesOperations.create_cluster

To test:

Create a cluster using

def test_create_cluster_with_registry_integration() -> None:
    cluster = client.kubernetes.create_cluster({
        'name': 'registry_enabled_test',
        'region': 'ams3',
        'version': '1.32',
        'registry_enabled': True,
    })

    assert cluster['kubernetes_cluster']['registry_enabled'], 'Expected registry to be enabled'

However, you will find that this assertion fails. Would you please be so kind as to fix this and adopt this test in your test suite?

Workaround

def test_create_cluster_with_registry_integration() -> None:
    cluster = client.kubernetes.create_cluster({
        'name': 'registry_enabled_test',
        'region': 'ams3',
        'version': '1.32',
        'registry_enabled': True,
    })

    client.kubernetes.add_registry({'cluster_uuids': [cluster['id'] for cluster in clusters['kubernetes_clusters']]})

    assert cluster['kubernetes_cluster']['registry_enabled'], 'Expected registry to be enabled'

Thank you,
Rein

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions