Merge pull request #27 from dmi3coder/feature/syncCode

made CaptureSession synchronous

Author: dmi3coder

src/main/java/de/dmi3y/behaiv/session/CaptureSession.java

@@ -23,14 +23,8 @@ public CaptureSession(List<Provider> providers) {
     }
 
     public void start(final Behaiv behaiv) {
-        new Thread(new Runnable()
-        {
-            @Override
-            public void run()
-            {
-                CaptureSession.this.startBlocking(behaiv);
-            }
-        }).start();
+        //we delegate asynchronous handling to library users for now
+        startBlocking(behaiv);
     }
 
     public void startBlocking(Behaiv behaiv) {
@@ -46,14 +40,11 @@ public void startBlocking(Behaiv behaiv) {
         if (featureList.size() == 0) {
             throw new InputMismatchException("Feature size shouldn't be zero");
         }
-        final List<Double> capturedFeatures = Single.zip(featureList, new Function<Object[], List<Double>>()
-        {
+        final List<Double> capturedFeatures = Single.zip(featureList, new Function<Object[], List<Double>>() {
             @Override
-            public List<Double> apply(Object[] objects) throws Throwable
-            {
+            public List<Double> apply(Object[] objects) {
                 List<Double> mapDoubleList = new ArrayList<>();
-                for (Object obj : objects)
-                {
+                for (Object obj : objects) {
                     mapDoubleList.addAll((List<Double>) obj);
                 }
                 return mapDoubleList;

src/test/java/de/dmi3y/behaiv/session/CaptureSessionTest.java

@@ -25,7 +25,8 @@ public void setUp() throws Exception {
 
     @Test(expected = InputMismatchException.class)
     public void startBlocking() {
-        session.startBlocking(null);
+        session = new CaptureSession(Collections.<Provider>emptyList());
+        session.start(null);
     }
 
     @Test
@@ -43,4 +44,13 @@ public void captureSession_fetchProviderData_receiveInCorrectOrder() {
             assertEquals(features.get(i).getValue(), "ord" + (i + 1));
         }
     }
+
+    @Test(expected = InputMismatchException.class)
+    public void captureSession_fetchProviderDataIncorrectSize_expectInputMismatchException() {
+        final List<Provider> providers = Arrays.<Provider>asList(
+                new TestSleepProvider(new String[]{"ord1", "ord2"}, new Double[]{1.0}, 200)
+        );
+        session = new CaptureSession(providers);
+        session.startBlocking(null);
+    }
 }