Enhancement: Add clarification on use of dlpack for kDLOneAPI devices #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no functional impact on the header file, only to modify the text associated with the kDLOneAPI enum. It accomplishes two things:
partitionmanager_ctxstruct member.While its clear that the
manager_ctxis predominantly used for proper data deletion, it can also provide this necessary information associated with SYCL and/or OpenCL peculiarities (namely 'contexts' in both, but also specifically devices for SYCL, etc.). This should be done in the hope that various implementers of the__dlpack__standard may try to additionally standardize the required additional information outside of dlpack.Continues some discussion from #78