Suppress CA1725: Parameter names should match base declaration

Author: bdukes

Build/Build.csproj

@@ -11,7 +11,7 @@
     <AnalysisLevel>latest</AnalysisLevel>
     <AnalysisMode>Recommended</AnalysisMode>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-    <WarningsNotAsErrors>CS0618,CA1725,CA5351</WarningsNotAsErrors>
+    <WarningsNotAsErrors>CS0618,CA5351</WarningsNotAsErrors>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
   </PropertyGroup>
   <ItemGroup>

Build/Lifetime.cs

@@ -7,7 +7,6 @@ namespace DotNetNuke.Build
     using Cake.Common;
     using Cake.Common.Diagnostics;
     using Cake.Core;
-    using Cake.Core.Diagnostics;
     using Cake.Core.IO;
     using Cake.Frosting;
 
@@ -17,7 +16,7 @@ public sealed class Lifetime : FrostingLifetime<Context>
         private static readonly string[] CorepackToolNames = ["corepack", "corepack.cmd",];
 
         /// <inheritdoc/>
-        public override void Setup(Context context, ISetupContext setupContext)
+        public override void Setup(Context context, ISetupContext info)
         {
             context.IsRunningInCI = context.HasEnvironmentVariable("TF_BUILD");
             context.Information("Is Running in CI : {0}", context.IsRunningInCI);

DNN Platform/Connectors/Azure/Dnn.AzureConnector.csproj

@@ -11,7 +11,6 @@
     <AnalysisMode>Recommended</AnalysisMode>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NoWarn>CS1591</NoWarn>
-    <WarningsNotAsErrors>CA1725</WarningsNotAsErrors>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
   </PropertyGroup>

DNN Platform/Connectors/Azure/Services/ServiceRouteMapper.cs

@@ -11,9 +11,9 @@ public class ServiceRouteMapper : IServiceRouteMapper
         private static readonly string[] Namespaces = ["Dnn.AzureConnector.Services",];
 
         /// <inheritdoc/>
-        public void RegisterRoutes(IMapRoute routeManager)
+        public void RegisterRoutes(IMapRoute mapRouteManager)
         {
-            routeManager.MapHttpRoute(
+            mapRouteManager.MapHttpRoute(
                 "AzureConnector",
                 "default",
                 "{controller}/{action}",

DNN Platform/DotNetNuke.Web/Components/Controllers/ControlBarController.cs

@@ -6,6 +6,7 @@ namespace DotNetNuke.Web.Components.Controllers
 {
     using System;
     using System.Collections.Generic;
+    using System.Diagnostics.CodeAnalysis;
     using System.Globalization;
     using System.IO;
     using System.Linq;
@@ -70,9 +71,10 @@ public IEnumerable<KeyValuePair<string, PortalDesktopModuleInfo>> GetBookmarkedD
 
             return this.GetBookmarkedModules(PortalSettings.Current.PortalId, userId)
                 .Where(kvp => kvp.Key.ToLower(CultureInfo.InvariantCulture).Contains(formattedSearchTerm));
-        }
-
+        }
+
         /// <inheritdoc/>
+        [SuppressMessage("Microsoft.Naming", "CA1725:ParameterNamesShouldMatchBaseDeclaration", Justification = "Breaking change")]
         public void SaveBookMark(int portalId, int userId, string bookmarkTitle, string bookmarkValue)
         {
             var ensuredBookmarkValue = bookmarkValue;

DNN Platform/DotNetNuke.Web/DotNetNuke.Web.csproj

@@ -11,7 +11,7 @@
     <AnalysisMode>Recommended</AnalysisMode>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NoWarn>CS1591</NoWarn>
-    <WarningsNotAsErrors>CS0618,SA1600,CA1725,CA3075,CA5351</WarningsNotAsErrors>
+    <WarningsNotAsErrors>CS0618,SA1600,CA3075,CA5351</WarningsNotAsErrors>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
   </PropertyGroup>

DNN Platform/DotNetNuke.Web/UI/WebControls/DnnFormEditor.cs

@@ -6,6 +6,7 @@ namespace DotNetNuke.Web.UI.WebControls
     using System;
     using System.Collections.Generic;
     using System.ComponentModel;
+    using System.Diagnostics.CodeAnalysis;
     using System.Text;
     using System.Web.UI;
     using System.Web.UI.WebControls;
@@ -165,6 +166,7 @@ protected virtual void CreateControlHierarchy(bool useDataSource)
         }
 
         /// <inheritdoc/>
+        [SuppressMessage("Microsoft.Naming", "CA1725:ParameterNamesShouldMatchBaseDeclaration", Justification = "Breaking change")]
         protected override void LoadControlState(object state)
         {
             if (state != null)

DNN Platform/DotNetNuke.Web/UI/WebControls/DnnFormItemBase.cs

@@ -269,6 +269,7 @@ protected void UpdateDataSource(object oldValue, object newValue, string dataFie
         }
 
         /// <inheritdoc/>
+        [SuppressMessage("Microsoft.Naming", "CA1725:ParameterNamesShouldMatchBaseDeclaration", Justification = "Breaking change")]
         protected override void LoadControlState(object state)
         {
             this.value = state;

DNN Platform/DotNetNuke.WebUtility/ClientAPIPostBackControl.vb

@@ -1,6 +1,7 @@
-' Copyright (c) .NET Foundation. All rights reserved.
+' Copyright (c) .NET Foundation. All rights reserved.
 ' Licensed under the MIT License. See LICENSE file in the project root for full license information.
 
+Imports System.Diagnostics.CodeAnalysis
 Imports System.Web.UI
 
 Namespace DotNetNuke.UI.Utilities
@@ -99,6 +100,7 @@ Namespace DotNetNuke.UI.Utilities
         ''' 	[Jon Henning]	9/15/2004	Created
         ''' </history>
         ''' -----------------------------------------------------------------------------
+        <SuppressMessage("Microsoft.Naming", "CA1725:ParameterNamesShouldMatchBaseDeclaration", Justification := "Breaking change")>
         Public Sub RaisePostBackEvent(ByVal strEventArgument As String) Implements System.Web.UI.IPostBackEventHandler.RaisePostBackEvent
             Dim objArg As ClientAPIPostBackEventArgs = New ClientAPIPostBackEventArgs(strEventArgument)
             If Not EventHandlers(objArg.EventName) Is Nothing Then

DNN Platform/DotNetNuke.WebUtility/DotNetNuke.WebUtility.vbproj

@@ -13,7 +13,7 @@
     <AnalysisMode>Recommended</AnalysisMode>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <NoWarn>42016,42017,42018,42019,42032,42353,42354,42355</NoWarn>
-    <WarningsNotAsErrors>CA1725,CA3075,CA5372</WarningsNotAsErrors>
+    <WarningsNotAsErrors>CA3075,CA5372</WarningsNotAsErrors>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
   </PropertyGroup>