Skip to content

Conversation

@tianon
Copy link
Member

@tianon tianon commented Nov 20, 2024

We don't need a full (unshallow) clone for any of these -- the jobs don't look at the commit history and we can make new commits without having history locally.

This will help on architectures that have been struggling to clone the repository since the move (because a "full" clone is now bigger than it was when we started all this), but is also generally better all around.

(I've tested this successfully on mips64le's failing build job: https://doi-janky.infosiftr.net/job/meta/job/mips64le/job/build/10430/console)

We don't need a full (unshallow) clone for any of these -- the jobs don't look at the commit history and we can make new commits without having history locally.

This will help on architectures that have been struggling to clone the repository since the move (because a "full" clone is now bigger than it was when we started all this), but is also generally better all around.
@tianon tianon requested a review from yosifkit as a code owner November 20, 2024 19:07
@tianon
Copy link
Member Author

tianon commented Nov 20, 2024

Hmm, should we go even further and add an explicit refspec and turn on the "honor refspec on clone" setting too so it only clones the single branch we care about? We don't often have more than one upstream branch so it doesn't actually make much functional difference, but it's part of this same data struct.

@yosifkit
Copy link
Member

Hmm, should we go even further and add an explicit refspec and turn on the "honor refspec on clone" setting too so it only clones the single branch we care about?

I don't think it matters either way since we almost never do branches on the main fork.

@tianon tianon merged commit c9abab7 into docker-library:main Nov 20, 2024
1 check passed
@tianon tianon deleted the jenkins-shallow-clone branch November 20, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants