Skip to content

Commit aba3f22

Browse files
committed
adapted unit tests
1 parent b2a5491 commit aba3f22

File tree

5 files changed

+36
-4
lines changed

5 files changed

+36
-4
lines changed

src/Cache/DoctrineCacheStorage.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ public function __construct($options, protected Cache $cache)
2828

2929
/**
3030
* {@inheritDoc}
31+
* @param-out bool $success
3132
*/
3233
protected function internalGetItem(&$normalizedKey, &$success = null, &$casToken = null)
3334
{

tests/Form/Element/ProxyTest.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -279,9 +279,7 @@ public function testExceptionThrownForNonCallableLabelGenerator(): void
279279
'TypeError',
280280
);
281281
$this->expectExceptionMessage(
282-
PHP_VERSION_ID >= 80000
283-
? 'DoctrineModule\Form\Element\Proxy::setLabelGenerator(): Argument #1 ($callable) must be of type callable'
284-
: 'Argument 1 passed to DoctrineModule\Form\Element\Proxy::setLabelGenerator() must be callable',
282+
'DoctrineModule\Form\Element\Proxy::setLabelGenerator(): Argument #1 ($callable) must be of type callable'
285283
);
286284

287285
$this->proxy->setOptions(['label_generator' => 'I throw an invalid type error']);
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
<?php
2+
3+
declare(strict_types=1);
4+
5+
namespace DoctrineModuleTest\Persistence;
6+
7+
use Doctrine\Persistence\ObjectManager;
8+
use DoctrineModuleTest\Persistence\TestAsset\DummyObjectManager;
9+
use PHPUnit\Framework\TestCase as BaseTestCase;
10+
11+
/**
12+
* Test for {@see \DoctrineModule\Persistence\ProvidesObjectManager}
13+
*/
14+
class ProvidesObjectManagerTest extends BaseTestCase
15+
{
16+
public function testSetAndGetObjectManager(): void
17+
{
18+
$objectManager = $this->createMock(ObjectManager::class);
19+
$dummy = new DummyObjectManager();
20+
$dummy->setObjectManager($objectManager);
21+
$retrieved = $dummy->getObjectManager();
22+
23+
$this->assertSame($dummy, $retrieved);
24+
}
25+
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
<?php
2+
3+
namespace DoctrineModuleTest\Persistence\TestAsset;
4+
5+
use DoctrineModule\Persistence\ProvidesObjectManager;
6+
7+
class DummyObjectManager {
8+
use ProvidesObjectManager;
9+
}

tests/Service/DriverFactoryTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ public function testCreateDriverChain(): void
6767
$factory = new DriverFactory('testChainDriver');
6868
$driver = $factory->__invoke($serviceManager, MappingDriverChain::class);
6969
$this->assertInstanceOf(MappingDriverChain::class, $driver);
70-
assert($driver instanceof MappingDriverChain);
7170

7271
$drivers = $driver->getDrivers();
7372
$this->assertCount(1, $drivers);

0 commit comments

Comments
 (0)