Merge pull request #422 from jawira/reflection-constructor

fix: Add parent constructor call in EnumReflectionProperty

Author: greg0ire

phpstan-baseline.neon

@@ -5,16 +5,6 @@ parameters:
 			count: 1
 			path: src/Persistence/Mapping/Driver/StaticPHPDriver.php
 
-		-
-			message: "#^Doctrine\\\\Persistence\\\\Reflection\\\\EnumReflectionProperty\\:\\:__construct\\(\\) does not call parent constructor from ReflectionProperty\\.$#"
-			count: 1
-			path: src/Persistence/Reflection/EnumReflectionProperty.php
-
-		-
-			message: "#^Method Doctrine\\\\Persistence\\\\Reflection\\\\EnumReflectionProperty\\:\\:getDeclaringClass\\(\\) return type with generic class ReflectionClass does not specify its types\\: T$#"
-			count: 1
-			path: src/Persistence/Reflection/EnumReflectionProperty.php
-
 		-
 			message: "#^Method Doctrine\\\\Persistence\\\\Reflection\\\\EnumReflectionProperty\\:\\:toEnum\\(\\) should return array\\<BackedEnum\\>\\|BackedEnum but returns array\\<BackedEnum\\|int\\|string\\>\\.$#"
 			count: 1

src/Persistence/Reflection/EnumReflectionProperty.php

@@ -5,9 +5,7 @@
 namespace Doctrine\Persistence\Reflection;
 
 use BackedEnum;
-use ReflectionClass;
 use ReflectionProperty;
-use ReflectionType;
 
 use function array_map;
 use function is_array;
@@ -21,29 +19,7 @@ class EnumReflectionProperty extends ReflectionProperty
     /** @param class-string<BackedEnum> $enumType */
     public function __construct(private readonly ReflectionProperty $originalReflectionProperty, private readonly string $enumType)
     {
-    }
-
-    public function getDeclaringClass(): ReflectionClass
-    {
-        return $this->originalReflectionProperty->getDeclaringClass();
-    }
-
-    public function getName(): string
-    {
-        return $this->originalReflectionProperty->getName();
-    }
-
-    public function getType(): ReflectionType|null
-    {
-        return $this->originalReflectionProperty->getType();
-    }
-
-    /**
-     * {@inheritDoc}
-     */
-    public function getAttributes(string|null $name = null, int $flags = 0): array
-    {
-        return $this->originalReflectionProperty->getAttributes($name, $flags);
+        parent::__construct($originalReflectionProperty->class, $originalReflectionProperty->name);
     }
 
     /**
@@ -120,19 +96,4 @@ private function toEnum(int|string|array|BackedEnum $value)
 
         return $this->enumType::from($value);
     }
-
-    public function getModifiers(): int
-    {
-        return $this->originalReflectionProperty->getModifiers();
-    }
-
-    public function getDocComment(): string|false
-    {
-        return $this->originalReflectionProperty->getDocComment();
-    }
-
-    public function isPrivate(): bool
-    {
-        return $this->originalReflectionProperty->isPrivate();
-    }
 }

tests/Persistence/Reflection/Reflection/EnumReflectionPropertyTest.php

@@ -135,6 +135,18 @@ public function testIsPrivate(): void
         $reflProperty = new EnumReflectionProperty(new ReflectionProperty(TypedEnumClass::class, 'suit'), Suit::class);
         self::assertFalse($reflProperty->isPrivate());
     }
+
+    public function testIsPublic(): void
+    {
+        $reflProperty = new EnumReflectionProperty(new ReflectionProperty(TypedEnumClass::class, 'suit'), Suit::class);
+        self::assertTrue($reflProperty->isPublic());
+    }
+
+    public function testHasDefaultValue(): void
+    {
+        $reflProperty = new EnumReflectionProperty(new ReflectionProperty(TypedEnumClass::class, 'suit'), Suit::class);
+        self::assertTrue($reflProperty->hasDefaultValue());
+    }
 }
 
 #[Attribute(Attribute::TARGET_PROPERTY)]