Conversation
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes address the restore issue and preserve expected nightly behavior.
Pull request overview
Fixes Central Package Management restore failures for nightly tests and the full solution while preserving nightly version replacement behavior.
Changes:
- Adds placeholder
PackageVersionentries for nightly and test framework dependencies. - Updates the nightly package version updater to modify
PackageVersionitems.
File summaries
| File | Description |
|---|---|
test/TestFrameworkDependency.props |
Adds the Microsoft.ML placeholder version. |
test/NightlyBuildDependency.props |
Adds placeholder versions for nightly dependencies. |
test/Microsoft.ML.NugetPackageVersionUpdater/Program.cs |
Updates central package versions during nightly builds. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
matouskozak
left a comment
There was a problem hiding this comment.
Looking good.
I'm curious, what plan do you have for the nightly runs? I'm not really sure why they got disabled in the pass, but we could definitely re-enable them if we thing it is worthy. My immediate thinking is that we could use it to run some deeper integration tests or some performance regression tests. Or we can revisit what configs we run on PRs and maybe move some less important jobs to nightly runs.
Just one thing to consider, that if we introduce nightly test runs, we should introduce it together with a monitoring system (e.g., agentic workflow) so that they remain healthy and don't regress often. cc: @svick as you were doing a lot of CI lately.
|
Well, agentic workflow is definitely an option when we will see the pipeline runs have enough value, first we need to try to get the pipeline to that point. I wonder if it could be a good place for more complicated e2e training and inference tests taking hours and therefore unfeasible for main/pr pipelines. |
Fixes
NU1010when restoringMicrosoft.ML.NightlyBuild.Testsor the full solution.The Central Package Management conversion removed the placeholder versions from the nightly package references without adding corresponding
PackageVersionitems. This caused solution restore, including restore initiated by C# Dev Kit, to fail.Changes
PackageVersionitems for the nightly-build dependencies.Microsoft.MLpackage version used byTestFrameworkDependency.props.Microsoft.ML.NugetPackageVersionUpdaterto rewritePackageVersionitems instead ofPackageReferenceitems.Validation
Microsoft.ML.NightlyBuild.TestswithReferenceTypeForTestFramework=NuGet.Microsoft.ML.sln.Microsoft.ML.NugetPackageVersionUpdater.