Rename analyzer AddDefaultAccessModifier to AddAccessibilityModifiers (RCS1018).

Author: josefpihrt

src/Analyzers.CodeFixes/CSharp/CodeFixes/MemberDeclarationCodeFixProvider.cs

@@ -28,7 +28,7 @@ public sealed override ImmutableArray<string> FixableDiagnosticIds
                 return ImmutableArray.Create(
                     DiagnosticIdentifiers.FormatDeclarationBraces,
                     DiagnosticIdentifiers.RemoveRedundantOverridingMember,
-                    DiagnosticIdentifiers.AddDefaultAccessModifier,
+                    DiagnosticIdentifiers.AddAccessibilityModifiers,
                     DiagnosticIdentifiers.RemoveRedundantSealedModifier,
                     DiagnosticIdentifiers.AvoidSemicolonAtEndOfDeclaration,
                     DiagnosticIdentifiers.OrderModifiers,
@@ -68,14 +68,14 @@ public sealed override async Task RegisterCodeFixesAsync(CodeFixContext context)
                             context.RegisterCodeFix(codeAction, diagnostic);
                             break;
                         }
-                    case DiagnosticIdentifiers.AddDefaultAccessModifier:
+                    case DiagnosticIdentifiers.AddAccessibilityModifiers:
                         {
                             var accessibility = (Accessibility)Enum.Parse(
                                 typeof(Accessibility),
                                 diagnostic.Properties[nameof(Accessibility)]);
 
                             CodeAction codeAction = CodeAction.Create(
-                                "Add default access modifier",
+                                "Add accessibility modifiers",
                                 cancellationToken => AddDefaultAccessModifierRefactoring.RefactorAsync(context.Document, memberDeclaration, accessibility, cancellationToken),
                                 GetEquivalenceKey(diagnostic));
 

src/Analyzers/Analyzers.xml

@@ -365,10 +365,10 @@ foreach (var item in items) // [|Id|]
       </Sample>
     </Samples>
   </Analyzer>
-  <Analyzer Identifier="AddDefaultAccessModifier">
+  <Analyzer Identifier="AddAccessibilityModifiers">
     <Id>RCS1018</Id>
-    <Title>Add default access modifier.</Title>
-    <MessageFormat>Add default access modifier.</MessageFormat>
+    <Title>Add accessibility modifiers.</Title>
+    <MessageFormat>Add accessibility modifiers.</MessageFormat>
     <Category>Readability</Category>
     <DefaultSeverity>Info</DefaultSeverity>
     <IsEnabledByDefault>true</IsEnabledByDefault>

…ysis/AddDefaultAccessModifierAnalyzer.cs …sis/AddAccessibilityModifiersAnalyzer.cssrc/Analyzers/CSharp/Analysis/AddDefaultAccessModifierAnalyzer.cs renamed to src/Analyzers/CSharp/Analysis/AddAccessibilityModifiersAnalyzer.cs src/Analyzers/CSharp/Analysis/AddDefaultAccessModifierAnalyzer.cs renamed to src/Analyzers/CSharp/Analysis/AddAccessibilityModifiersAnalyzer.cs

@@ -13,11 +13,11 @@
 namespace Roslynator.CSharp.Analysis
 {
     [DiagnosticAnalyzer(LanguageNames.CSharp)]
-    public class AddDefaultAccessModifierAnalyzer : BaseDiagnosticAnalyzer
+    public class AddAccessibilityModifiersAnalyzer : BaseDiagnosticAnalyzer
     {
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
         {
-            get { return ImmutableArray.Create(DiagnosticDescriptors.AddDefaultAccessModifier); }
+            get { return ImmutableArray.Create(DiagnosticDescriptors.AddAccessibilityModifiers); }
         }
 
         public override void Initialize(AnalysisContext context)
@@ -155,7 +155,7 @@ private static void Analyze(SyntaxNodeAnalysisContext context, MemberDeclaration
                 return;
 
             DiagnosticHelpers.ReportDiagnostic(context,
-                DiagnosticDescriptors.AddDefaultAccessModifier,
+                DiagnosticDescriptors.AddAccessibilityModifiers,
                 location,
                 ImmutableDictionary.CreateRange(new KeyValuePair<string, string>[] { new KeyValuePair<string, string>(nameof(Accessibility), accessibility.ToString()) }));
         }

src/Analyzers/CSharp/DiagnosticDescriptors.Generated.cs

@@ -214,15 +214,15 @@ public static partial class DiagnosticDescriptors
             customTags:         Array.Empty<string>());
 
         /// <summary>RCS1018</summary>
-        public static readonly DiagnosticDescriptor AddDefaultAccessModifier = new DiagnosticDescriptor(
-            id:                 DiagnosticIdentifiers.AddDefaultAccessModifier, 
-            title:              "Add default access modifier.", 
-            messageFormat:      "Add default access modifier.", 
+        public static readonly DiagnosticDescriptor AddAccessibilityModifiers = new DiagnosticDescriptor(
+            id:                 DiagnosticIdentifiers.AddAccessibilityModifiers, 
+            title:              "Add accessibility modifiers.", 
+            messageFormat:      "Add accessibility modifiers.", 
             category:           DiagnosticCategories.Readability, 
             defaultSeverity:    DiagnosticSeverity.Info, 
             isEnabledByDefault: true, 
             description:        null, 
-            helpLinkUri:        $"{HelpLinkUriRoot}{DiagnosticIdentifiers.AddDefaultAccessModifier}", 
+            helpLinkUri:        $"{HelpLinkUriRoot}{DiagnosticIdentifiers.AddAccessibilityModifiers}", 
             customTags:         Array.Empty<string>());
 
         /// <summary>RCS1019</summary>

src/Analyzers/CSharp/DiagnosticIdentifiers.Generated.cs

@@ -24,7 +24,7 @@ public static partial class DiagnosticIdentifiers
         public const string UseNameOfOperator = "RCS1015";
         public const string UseExpressionBodiedMember = "RCS1016";
         public const string AvoidMultilineExpressionBody = "RCS1017";
-        public const string AddDefaultAccessModifier = "RCS1018";
+        public const string AddAccessibilityModifiers = "RCS1018";
         public const string OrderModifiers = "RCS1019";
         public const string SimplifyNullableOfT = "RCS1020";
         public const string SimplifyLambdaExpression = "RCS1021";

src/VisualStudio.Common/GlobalSuppressionsOptionsPage.Generated.cs

@@ -34,7 +34,7 @@ protected override void Fill(ICollection<BaseModel> analyzers)
             analyzers.Add(new BaseModel("RCS1015", "Use nameof operator.", !IsEnabled("RCS1015")));
             analyzers.Add(new BaseModel("RCS1016", "Use expression-bodied member.", !IsEnabled("RCS1016")));
             analyzers.Add(new BaseModel("RCS1017", "Avoid multiline expression body.", !IsEnabled("RCS1017")));
-            analyzers.Add(new BaseModel("RCS1018", "Add default access modifier.", !IsEnabled("RCS1018")));
+            analyzers.Add(new BaseModel("RCS1018", "Add accessibility modifiers.", !IsEnabled("RCS1018")));
             analyzers.Add(new BaseModel("RCS1019", "Order modifiers.", !IsEnabled("RCS1019")));
             analyzers.Add(new BaseModel("RCS1020", "Simplify Nullable<T> to T?.", !IsEnabled("RCS1020")));
             analyzers.Add(new BaseModel("RCS1021", "Simplify lambda expression.", !IsEnabled("RCS1021")));