Change Durable Object SQLite migrate function to be sync #5014
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change DO SQLite migrate function to be in line with other existing sync SQL adapters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change DO SQLite
migratefunction to be in line with other existing sync SQL adaptersThis change was motivated by noticing that the setup in Durable Objects was more complicated than required as seen in the docs.
Since
migrateis currently async, it seems to require the usage ofctx.blockConcurrencyWhilein the setup step of the object, which introduces more things the user has to understand before using the drizzle with Durable Objects.(In reality, I believe no microtasks are actually ever scheduled since no await is encountered inside migrate, so you wouldn't need to use ctx.blockConcurrencyWhile to guarentee the setup working, but the function being async makes it seem like you do)
I also intend to make a PR on the docs to simplify the setup for new users of Drizzle + Cloudflare Durable Objects.