Skip to content

Conversation

@Olyno
Copy link
Contributor

@Olyno Olyno commented Oct 23, 2025

Description

This pull request should avoid users to lose their prompts.

Closes #1301


Summary by cubic

Prevents the update dialog from resetting in-progress prompts. After downloading an update, the app asks to restart instead of auto-restarting.

  • Bug Fixes
    • Use update-electron-app onNotifyUser to show a Restart/Later dialog.
    • Restart only when confirmed (autoUpdater.quitAndInstall); otherwise keep the session.
    • Cleaned up imports and added MessageBoxOptions typing.

Written for commit a35d04a. Summary will update automatically on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@wwwillchen
Copy link
Contributor

@Olyno i don't understand how this fixes the issue. it seems functionally equivalent to the built-in dialog that electron updater has: https://github.com/electron/update-electron-app/blob/379618e570337c568cbadb89709f88a41134e7ad/src/index.ts#L256-L284 - could you explain how this is different from the current behavior?

@Olyno
Copy link
Contributor Author

Olyno commented Oct 30, 2025

I agree, it can be quite confusing at first. Basically, instead of making the "accept update" as default, it becomes the "close" action, which avoids running the update, and losing the prompt.

In short, instead of accepting the update when pressing Enter, we simply close the update popup. @wwwillchen

@wwwillchen
Copy link
Contributor

@Olyno sorry for the slow response. i don't think this is the right approach because then users may inadvertently skip updates, and some of them are quite important for fixing bugs, etc.
instead, i think we should probably have a more discrete upgrade UI (similar to Cursor and other products) where a banner tells users that an upgrade is available and they can choose when to upgrade.

@wwwillchen wwwillchen closed this Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] <Lost Entire Prompt Due to Update Pop-Up>

2 participants