Automate "SSH key with passphrase configuration from the User Dashboard" test-case #23643
Conversation
SkorikSergey
added
area/qe
status/code-review
SkorikSergey
requested review from
dmytro-ndp and
musienko-maxim
as code owners
| 'ssh://[email protected]/~admin/private-bb-repo.git'; | ||
| const privateSshKey: string = FACTORY_TEST_CONSTANTS.TS_SELENIUM_SSH_PRIVATE_KEY; | ||
| const publicSshKey: string = FACTORY_TEST_CONSTANTS.TS_SELENIUM_SSH_PUBLIC_KEY; | ||
| const sshPassphrase: string = FACTORY_TEST_CONSTANTS.TS_SELENIUM_SSH_PASSPHRASE; |
There was a problem hiding this comment.
Correct name is TS_SELENIUM_SSH_KEY_PASSPHRASE.
| TS_SELENIUM_SSH_PUBLIC_KEY: process.env.TS_SELENIUM_SSH_PUBLIC_KEY || '', | ||
|
|
||
| /** | ||
| * ssh passphrase as string (from environment variable) |
There was a problem hiding this comment.
it would better to say "ssh key passphrase" to avoid confusion
| /** | ||
| * ssh passphrase as string (from environment variable) | ||
| */ | ||
| TS_SELENIUM_SSH_PASSPHRASE: process.env.TS_SELENIUM_SSH_PASSPHRASE || '', |
There was a problem hiding this comment.
correct name is TS_SELENIUM_SSH_KEY_PASSPHRASE
|
@SkorikSergey: thank you for test automation! It's also important to ensure in the test that push inside the workspace without personal access token using either terminal or source control view works without asking for the passphrase. See an example of push verification in the test https://github.com/eclipse-che/che/blob/main/tests/e2e/specs/factory/NoSetupRepoFactory.spec.ts#L192-L251 |
|
@SkorikSergey: thank you for pointing out the fact that
Please add |
SkorikSergey
added
status/in-progress
What does this PR do?
Automate "SSH key with passphrase configuration from the User Dashboard" test-case
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-5392
How to test this PR?
To test this PR:
TS_SELENIUM_SSH_PRIVATE_KEYandTS_SELENIUM_SSH_PUBLIC_KEYTS_SELENIUM_SSH_PASSPHRASETS_SELENIUM_FACTORY_GIT_REPO_URLfor repo urlSshUrlNoOauthPatFactorye2e testPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.