Memory view not supporting 64-bit address while using GnuMcuLaunch

[pnipin]

While using GnuMcuLaunch (which is used to initialize the memory bloc retrieval used by the Peripherals view), Memory view is showing error "Unable to load memory from specified address" for 64-bit addresses. Please see the screen shot below:

Going through the code, can see PeripheralMemoryBlockRetrieval extends the parent class DsfMemoryBlockRetrieval which does not have code for handling address size. If I change the parent class of PeripheralMemoryBlockRetrieval to GdbMemoryBlockRetrieval memory view correctly displays the address contents.

Am I missing anything? I could not find any embedded CDT bug related to 64-bit address display in memory view.

[jonahgraham]

I don't think you are missing anything - PRs are encouraged and welcome. I think you are correct in that is the fix (Dsf -> Gdb memory blocks) as you noted. The missing delegation to Gdb memory blocks to get address size in the gdb variant here is indeed quite important for 64-bit.

[pnipin]

Thank you very much. I shall raise a PR for this ASAP.