[5762] Apply the selection requested by a tool to the workbench

pcdavid · pcdavid · commit cbf07e77d3aa · 2025-11-03T16:45:27.000+01:00
Bug: #5762 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc
@@ -61,7 +61,7 @@ Use `org.eclipse.emf.ecore.util.ECrossReferenceAdapter.getCrossReferenceAdapter(
 - https://github.com/eclipse-sirius/sirius-web/issues/5658[#5658] [diagram] Make labels non-draggable in read-only mode
 - https://github.com/eclipse-sirius/sirius-web/issues/5661[#5661] [diagram] Fix missing edge markers in SVG export
 - https://github.com/eclipse-sirius/sirius-web/issues/5755[#5755] [diagram] Fix an issue where EdgeCreationHandle was not rendered after an edge creation
-
+- https://github.com/eclipse-sirius/sirius-web/issues/5762[#5762] [diagram] Fix an issue where the selection requested by a diagram tool was no longer applied globaly to the workbench
 
 === New Features
 
diff --git a/packages/diagrams/frontend/sirius-components-diagrams/src/renderer/DiagramRenderer.tsx b/packages/diagrams/frontend/sirius-components-diagrams/src/renderer/DiagramRenderer.tsx
@@ -232,7 +232,10 @@ export const DiagramRenderer = memo(({ diagramRefreshedEventPayload }: DiagramRe
         }
       });
     }
-  }, [diagramRefreshedEventPayload, diagramDescription]);
+    if (selectionFromTool) {
+      setSelection(selectionFromTool);
+    }
+  }, [diagramRefreshedEventPayload, diagramDescription, setSelection]);
 
   useEffect(() => {
     if (toolSelections.has(diagramRefreshedEventPayload.id)) {

Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,10 @@ export const DiagramRenderer = memo(({ diagramRefreshedEventPayload }: DiagramRe`
`232`	`232`	`}`
`233`	`233`	`});`
`234`	`234`	`}`
`235`		`- }, [diagramRefreshedEventPayload, diagramDescription]);`
	`235`	`+ if (selectionFromTool) {`
	`236`	`+ setSelection(selectionFromTool);`
	`237`	`+ }`
	`238`	`+ }, [diagramRefreshedEventPayload, diagramDescription, setSelection]);`
`236`	`239`
`237`	`240`	`useEffect(() => {`
`238`	`241`	`if (toolSelections.has(diagramRefreshedEventPayload.id)) {`