-
Notifications
You must be signed in to change notification settings - Fork 239
Open
Labels
enhancementRequest for new or improved functionalityRequest for new or improved functionalityobservabilityLogging, monitoring, auditing, metrics, or alerting improvementsLogging, monitoring, auditing, metrics, or alerting improvementspriority:lowNice-to-have or can wait for community contributionsNice-to-have or can wait for community contributionsserver(Component: server) Backend platform and service-side functionality(Component: server) Backend platform and service-side functionality
Description
In certain cases, e.g. when publishing an extension fails, the server logs a warning together with the exception that was raised.
That leads to the case that the full stacktrace is logged, which seems unnecessary for defined error states like missing login or not signing the publisher agreement:
2025-11-06T13:11:54.733Z WARN [openvsx-server,e837dfb0320345c873f98217778bf07b,5d5552628336f274] 1 --- [openvsx-server] [045343603-12574] [e837dfb0320345c873f98217778bf07b-5d5552628336f274] org.eclipse.openvsx.RegistryAPI : Failed to publish extension
org.eclipse.openvsx.util.ErrorResultException: You must log in with an Eclipse Foundation account and sign a Publisher Agreement before publishing any extension.
at org.eclipse.openvsx.eclipse.EclipseService.checkPublisherAgreement(EclipseService.java:113)
at jdk.internal.reflect.GeneratedMethodAccessor555.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:360)
at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:724)
at org.eclipse.openvsx.eclipse.EclipseService$$SpringCGLIB$$0.checkPublisherAgreement(<generated>)
at org.eclipse.openvsx.LocalRegistryService.publish(LocalRegistryService.java:648)
at org.eclipse.openvsx.LocalRegistryService.publish(LocalRegistryService.java:635)
A stacktrace is useful for unexpected errors, but all occurrences of ErrorResultException seem to be expected, so I would assume that just logging the message would be good enough. wdyt?
Metadata
Metadata
Assignees
Labels
enhancementRequest for new or improved functionalityRequest for new or improved functionalityobservabilityLogging, monitoring, auditing, metrics, or alerting improvementsLogging, monitoring, auditing, metrics, or alerting improvementspriority:lowNice-to-have or can wait for community contributionsNice-to-have or can wait for community contributionsserver(Component: server) Backend platform and service-side functionality(Component: server) Backend platform and service-side functionality