Commit 348846e
authored
The `internetarchive` module has been split off as a new package named `wayback` (we’re replacing an older, unmaintained package of the same name). This updates our code here to use it and delete the old `internetarchive` module.
Some parts of the `internetarchive` module (namely formatting memento responses as dicts) were not generic, and so have been moved directly into `cli` because they did not make sense as part of the new `wayback` package. They’ll probably be further refactored later.
This change was originally done in #511, but that PR was incomplete and had to be reverted. Fixes applied here:
- Fixed references to error types. These require importing from a private part of wayback, so we might want to merge and release edgi-govdata-archiving/wayback#7, which provides public access to those, first.
- Fixed some broken method calls.
- Fix the fact that date got renamed to timestamp on CdxRecord right before the 0.2.0 release.
- Add an end-to-end test that runs the whole import process, and covers some of the error cases we encounter from the various clients. It’s not perfect and doesn’t cover all errors, but was a lot quicker to get done than a completely custom test with mock client instances that purposely trigger all the various possible errors.
1 parent 7a83cf9 commit 348846e
File tree
16 files changed
+13344
-1617
lines changed- docs/source
- scripts
- web_monitoring
- tests
- cassettes
- cli
- ia
16 files changed
+13344
-1617
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | | - | |
28 | 26 | | |
29 | 27 | | |
30 | 28 | | |
| |||
102 | 100 | | |
103 | 101 | | |
104 | 102 | | |
105 | | - | |
| 103 | + | |
106 | 104 | | |
107 | 105 | | |
108 | 106 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | 24 | | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
61 | 62 | | |
62 | 63 | | |
63 | 64 | | |
64 | | - | |
65 | | - | |
66 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
67 | 68 | | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
| |||
0 commit comments