Pre-commit Hook misses Commits with Lint Errors

[BeckettFrey]

I'm sure this is probably a very simple fix, but I noticed husky precommit passes when changes are unstaged. This creates a minor annoyance if you forget to stage changes that address linting.

[Mr0grog]

Git hooks can always be bypassed, whether installed via Husky or otherwise. That’s why we also lint in CI. What are you expecting to be different or thinking you would change here?

[BeckettFrey]

Git hooks can always be bypassed, whether installed via Husky or otherwise. That’s why we also lint in CI. What are you expecting to be different or thinking you would change here?

I just noticed that If I try to commit and get linting errors that prevent it, then I fix the linting errors and forget to stage the change it will let me commit even though the commit is identical to what it was.

The change would be to have the precommit hooks reference the staged version of files.

[Mr0grog]

Ahhhhhh, sorry, somehow I completely misread what you wrote and thought it was about bypassing the check, not disk vs. staged.

I understand where you’re coming from here, but I feel a little reluctant to add more tooling around this. I've actually been considering removing Husky and the pre-commit hook, since I don’t personally find it useful and is more dependency mess to maintain. Will have to think about this.

[BeckettFrey]

Ahhhhhh, sorry, somehow I completely misread what you wrote and thought it was about bypassing the check, not disk vs. staged.

I understand where you’re coming from here, but I feel a little reluctant to add more tooling around this. I've actually been considering removing Husky and the pre-commit hook, since I don’t personally find it useful and is more dependency mess to maintain. Will have to think about this.

No worries it was rather vague, it's up to you.