Add a test and let the defaulter return error

Author: t-persson

internal/webhook/v1alpha2/iut_webhook.go

@@ -32,19 +32,13 @@ import (
 )
 
 // nolint:unused
-// log is for logging in this package.
-var (
-	iutlog = logf.Log.WithName("iut-resource")
-	cli    client.Client
-)
+// iutlog is for logging in this package.
+var iutlog = logf.Log.WithName("iut-resource")
 
 // SetupIutWebhookWithManager registers the webhook for Iut in the manager.
 func SetupIutWebhookWithManager(mgr ctrl.Manager) error {
-	if cli == nil {
-		cli = mgr.GetClient()
-	}
 	return ctrl.NewWebhookManagedBy(mgr).For(&etosv1alpha2.Iut{}).
-		WithDefaulter(&IutCustomDefaulter{}).
+		WithDefaulter(&IutCustomDefaulter{mgr.GetClient()}).
 		Complete()
 }
 
@@ -56,6 +50,7 @@ func SetupIutWebhookWithManager(mgr ctrl.Manager) error {
 // NOTE: The +kubebuilder:object:generate=false marker prevents controller-gen from generating DeepCopy methods,
 // as it is used only for temporary operations and does not need to be deeply copied.
 type IutCustomDefaulter struct {
+	client.Reader
 }
 
 var _ webhook.CustomDefaulter = &IutCustomDefaulter{}
@@ -71,11 +66,15 @@ func (d *IutCustomDefaulter) Default(ctx context.Context, obj runtime.Object) er
 
 	environmentrequest := &v1alpha1.EnvironmentRequest{}
 	namespacedName := types.NamespacedName{Name: iut.Spec.EnvironmentRequest, Namespace: iut.Namespace}
-	if err := cli.Get(ctx, namespacedName, environmentrequest); err != nil {
+	if err := d.Get(ctx, namespacedName, environmentrequest); err != nil {
 		iutlog.Error(err, "name", iut.Name, "namespace", iut.Namespace, "environmentRequest", namespacedName.Name,
 			"Failed to get environmentrequest in namespace")
+		return err
 	}
 
+	if iut.Labels == nil {
+		iut.Labels = make(map[string]string)
+	}
 	iut.Labels["etos.eiffel-community.github.io/environment-request"] = environmentrequest.Spec.Name
 	iut.Labels["etos.eiffel-community.github.io/environment-request-id"] = environmentrequest.Spec.ID
 	iut.Labels["etos.eiffel-community.github.io/provider"] = iut.Spec.ProviderID

internal/webhook/v1alpha2/iut_webhook_test.go

@@ -19,43 +19,67 @@ package v1alpha2
 import (
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
+	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 
+	etosv1alpha1 "github.com/eiffel-community/etos/api/v1alpha1"
 	etosv1alpha2 "github.com/eiffel-community/etos/api/v1alpha2"
-	// TODO (user): Add any additional imports if needed
 )
 
 var _ = Describe("Iut Webhook", func() {
 	var (
 		obj       *etosv1alpha2.Iut
 		oldObj    *etosv1alpha2.Iut
 		defaulter IutCustomDefaulter
+
+		requestID           = "89224612-3851-45c9-95c0-72b719ae46ea"
+		requestIdentifier   = "fbb4096d-6529-4c39-bac3-08a7e45bf69a"
+		requestName         = "test-environment-request"
+		requestLabelCluster = "cluster-sample"
+		providerID          = "iut-provider-sample"
 	)
 
 	BeforeEach(func() {
+		environmentRequest := etosv1alpha1.EnvironmentRequest{
+			ObjectMeta: v1.ObjectMeta{
+				Labels: map[string]string{
+					"etos.eiffel-community.github.io/cluster": requestLabelCluster,
+				},
+			},
+			Spec: etosv1alpha1.EnvironmentRequestSpec{
+				Identifier: requestIdentifier,
+				Name:       requestName,
+				ID:         requestID,
+			},
+		}
 		obj = &etosv1alpha2.Iut{}
 		oldObj = &etosv1alpha2.Iut{}
-		defaulter = IutCustomDefaulter{}
+		defaulter = IutCustomDefaulter{FakeReader(&environmentRequest, nil)}
 		Expect(defaulter).NotTo(BeNil(), "Expected defaulter to be initialized")
 		Expect(oldObj).NotTo(BeNil(), "Expected oldObj to be initialized")
 		Expect(obj).NotTo(BeNil(), "Expected obj to be initialized")
-		// TODO (user): Add any setup logic common to all tests
 	})
 
 	AfterEach(func() {
-		// TODO (user): Add any teardown logic common to all tests
 	})
 
 	Context("When creating Iut under Defaulting Webhook", func() {
-		// TODO (user): Add logic for defaulting webhooks
-		// Example:
-		// It("Should apply defaults when a required field is empty", func() {
-		//     By("simulating a scenario where defaults should be applied")
-		//     obj.SomeFieldWithDefault = ""
-		//     By("calling the Default method to apply defaults")
-		//     defaulter.Default(ctx, obj)
-		//     By("checking that the default values are set")
-		//     Expect(obj.SomeFieldWithDefault).To(Equal("default_value"))
-		// })
+		It("Should apply defaults when a required field is empty", func() {
+			By("simulating a scenario where defaults should be applied")
+			obj.Labels = nil
+			obj.Spec.ProviderID = providerID
+			By("calling the Default method to apply defaults")
+			defaulter.Default(ctx, obj)
+			By("checking that the default values are set")
+			Expect(obj.Labels).To(Equal(map[string]string{
+				"etos.eiffel-community.github.io/environment-request":    requestName,
+				"etos.eiffel-community.github.io/environment-request-id": requestID,
+				"etos.eiffel-community.github.io/cluster":                requestLabelCluster,
+				"etos.eiffel-community.github.io/provider":               providerID,
+				"etos.eiffel-community.github.io/id":                     requestIdentifier,
+				"app.kubernetes.io/part-of":                              "etos",
+				"app.kubernetes.io/name":                                 "iut-provider",
+			}))
+		})
 	})
 
 })