From 15e70df5f5ea932908219ed1646bd06ecf55f36a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Danielle=20For=C3=A9?= Date: Tue, 28 Jul 2026 09:31:51 -0700 Subject: [PATCH 1/2] ConversationList: remove unused conversation_focused --- src/ConversationList/ConversationList.vala | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/src/ConversationList/ConversationList.vala b/src/ConversationList/ConversationList.vala index 8eaac42e2..608bd452a 100644 --- a/src/ConversationList/ConversationList.vala +++ b/src/ConversationList/ConversationList.vala @@ -22,7 +22,6 @@ public class Mail.ConversationList : Gtk.Box { public signal void conversation_selected (Camel.FolderThreadNode? node); - public signal void conversation_focused (Camel.FolderThreadNode? node); private const int MARK_READ_TIMEOUT_SECONDS = 5; @@ -170,19 +169,13 @@ public class Mail.ConversationList : Gtk.Box { mark_read_timeout_id = 0; } - if (row == null) { - conversation_focused (null); - } else { - conversation_focused (((ConversationItemModel) row).node); - - if (((ConversationItemModel) row).unread) { - mark_read_timeout_id = GLib.Timeout.add_seconds (MARK_READ_TIMEOUT_SECONDS, () => { - set_thread_flag (((ConversationItemModel) row).node, Camel.MessageFlags.SEEN); + if (row != null && ((ConversationItemModel) row).unread) { + mark_read_timeout_id = GLib.Timeout.add_seconds (MARK_READ_TIMEOUT_SECONDS, () => { + set_thread_flag (((ConversationItemModel) row).node, Camel.MessageFlags.SEEN); - mark_read_timeout_id = 0; - return false; - }); - } + mark_read_timeout_id = 0; + return false; + }); } }); @@ -233,7 +226,6 @@ public class Mail.ConversationList : Gtk.Box { cancellable.cancel (); } - conversation_focused (null); conversation_selected (null); uint previous_items = list_store.get_n_items (); From 97687e2d94fde2ba7f2abafe9006d67169783676 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Danielle=20For=C3=A9?= Date: Tue, 28 Jul 2026 09:42:07 -0700 Subject: [PATCH 2/2] Update src/ConversationList/ConversationList.vala Co-authored-by: Leo --- src/ConversationList/ConversationList.vala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ConversationList/ConversationList.vala b/src/ConversationList/ConversationList.vala index 608bd452a..3656d09c1 100644 --- a/src/ConversationList/ConversationList.vala +++ b/src/ConversationList/ConversationList.vala @@ -174,7 +174,7 @@ public class Mail.ConversationList : Gtk.Box { set_thread_flag (((ConversationItemModel) row).node, Camel.MessageFlags.SEEN); mark_read_timeout_id = 0; - return false; + return Source.REMOVE; }); } });