Skip to content

Commit bdde7f4

Browse files
authored
Merge pull request #243 from jmbockhorst/fixImports
Fix possible imports for packages not in ranking list
2 parents b1c0dfb + 05f9e7d commit bdde7f4

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

src/util/importUtils.ts

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export class ImportUtils {
5353
}
5454

5555
const ranking = RANKING_LIST as {
56-
[index: string]: string;
56+
[index: string]: string | undefined;
5757
};
5858

5959
exposedValues.sort((a, b) => {
@@ -62,7 +62,18 @@ export class ImportUtils {
6262
} else if (a.package && !b.package) {
6363
return 1;
6464
} else if (a.package && b.package) {
65-
return ranking[a.package].localeCompare(ranking[b.package]);
65+
const aRanking = ranking[a.package];
66+
const bRanking = ranking[b.package];
67+
68+
if (aRanking && bRanking) {
69+
return aRanking.localeCompare(bRanking);
70+
} else if (aRanking) {
71+
return 1;
72+
} else if (bRanking) {
73+
return -1;
74+
} else {
75+
return 0;
76+
}
6677
} else {
6778
return 0;
6879
}

0 commit comments

Comments
 (0)