Skip to content

Conversation

@bespsm
Copy link
Contributor

@bespsm bespsm commented Nov 16, 2025

bespsm added a commit to bespsm/embassy that referenced this pull request Nov 16, 2025
@i509VCB
Copy link
Member

i509VCB commented Nov 16, 2025

The hardware is natively fixed point from what I can tell. I'm not sure as to why we would be converting to f32 for the user?

@bespsm
Copy link
Contributor Author

bespsm commented Nov 16, 2025

The hardware is natively fixed point from what I can tell. I'm not sure as to why we would be converting to f32 for the user?

Do you suggest, to make end-user to convert fixed-point data?

@bespsm
Copy link
Contributor Author

bespsm commented Nov 21, 2025

@i509VCB I fixed the pipeline, please check

@bespsm
Copy link
Contributor Author

bespsm commented Nov 24, 2025

@i509VCB more concerns or shall we merge?

@i509VCB
Copy link
Member

i509VCB commented Nov 24, 2025

Probably good to merge for now. We can address fixed point operations later.

@i509VCB i509VCB added this pull request to the merge queue Nov 24, 2025
Merged via the queue into embassy-rs:main with commit 5ffb369 Nov 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants