diff --git a/README.md b/README.md index 5cd3427637..3876fac378 100644 --- a/README.md +++ b/README.md @@ -560,24 +560,25 @@ To disable a rule for an entire `.gjs`/`.gts` file, use a regular ESLint file-le ### Testing -| Name                                       | Description | 💼 | 🔧 | 💡 | -| :----------------------------------------------------------------------------------------------------- | :------------------------------------------------------------------------------------------------------- | :- | :- | :- | -| [no-current-route-name](docs/rules/no-current-route-name.md) | disallow usage of the `currentRouteName()` test helper | | | | -| [no-ember-testing-in-module-scope](docs/rules/no-ember-testing-in-module-scope.md) | disallow use of `Ember.testing` in module scope | ✅ | | | -| [no-invalid-test-waiters](docs/rules/no-invalid-test-waiters.md) | disallow incorrect usage of test waiter APIs | ✅ | | | -| [no-legacy-test-waiters](docs/rules/no-legacy-test-waiters.md) | disallow the use of the legacy test waiter APIs | ✅ | | | -| [no-noop-setup-on-error-in-before](docs/rules/no-noop-setup-on-error-in-before.md) | disallows using no-op setupOnerror in `before` or `beforeEach` | ✅ | 🔧 | | -| [no-pause-test](docs/rules/no-pause-test.md) | disallow usage of the `pauseTest` helper in tests | ✅ | | | -| [no-replace-test-comments](docs/rules/no-replace-test-comments.md) | disallow 'Replace this with your real tests' comments in test files | | | | -| [no-restricted-resolver-tests](docs/rules/no-restricted-resolver-tests.md) | disallow the use of patterns that use the restricted resolver in tests | ✅ | | | -| [no-settled-after-test-helper](docs/rules/no-settled-after-test-helper.md) | disallow usage of `await settled()` right after test helper that calls it internally | ✅ | 🔧 | | -| [no-test-and-then](docs/rules/no-test-and-then.md) | disallow usage of the `andThen` test wait helper | ✅ | | | -| [no-test-import-export](docs/rules/no-test-import-export.md) | disallow importing of "-test.js" in a test file and exporting from a test file | ✅ | | | -| [no-test-module-for](docs/rules/no-test-module-for.md) | disallow usage of `moduleFor`, `moduleForComponent`, etc | ✅ | | | -| [no-test-support-import](docs/rules/no-test-support-import.md) | disallow importing of "test-support" files in production code. | ✅ | | | -| [no-test-this-render](docs/rules/no-test-this-render.md) | disallow usage of the `this.render` in tests, recommending to use @ember/test-helpers' `render` instead. | ✅ | | | -| [prefer-ember-test-helpers](docs/rules/prefer-ember-test-helpers.md) | enforce usage of `@ember/test-helpers` methods over native window methods | ✅ | | | -| [require-valid-css-selector-in-test-helpers](docs/rules/require-valid-css-selector-in-test-helpers.md) | disallow using invalid CSS selectors in test helpers | ✅ | 🔧 | | +| Name                                       | Description | 💼 | 🔧 | 💡 | +| :----------------------------------------------------------------------------------------------------- | :-------------------------------------------------------------------------------------------------------------- | :- | :- | :- | +| [no-current-route-name](docs/rules/no-current-route-name.md) | disallow usage of the `currentRouteName()` test helper | | | | +| [no-ember-testing-in-module-scope](docs/rules/no-ember-testing-in-module-scope.md) | disallow use of `Ember.testing` in module scope | ✅ | | | +| [no-invalid-test-waiters](docs/rules/no-invalid-test-waiters.md) | disallow incorrect usage of test waiter APIs | ✅ | | | +| [no-legacy-test-waiters](docs/rules/no-legacy-test-waiters.md) | disallow the use of the legacy test waiter APIs | ✅ | | | +| [no-noop-setup-on-error-in-before](docs/rules/no-noop-setup-on-error-in-before.md) | disallows using no-op setupOnerror in `before` or `beforeEach` | ✅ | 🔧 | | +| [no-pause-test](docs/rules/no-pause-test.md) | disallow usage of the `pauseTest` helper in tests | ✅ | | | +| [no-replace-test-comments](docs/rules/no-replace-test-comments.md) | disallow 'Replace this with your real tests' comments in test files | | | | +| [no-restricted-resolver-tests](docs/rules/no-restricted-resolver-tests.md) | disallow the use of patterns that use the restricted resolver in tests | ✅ | | | +| [no-settled-after-test-helper](docs/rules/no-settled-after-test-helper.md) | disallow usage of `await settled()` right after test helper that calls it internally | ✅ | 🔧 | | +| [no-test-and-then](docs/rules/no-test-and-then.md) | disallow usage of the `andThen` test wait helper | ✅ | | | +| [no-test-import-export](docs/rules/no-test-import-export.md) | disallow importing of "-test.js" in a test file and exporting from a test file | ✅ | | | +| [no-test-module-for](docs/rules/no-test-module-for.md) | disallow usage of `moduleFor`, `moduleForComponent`, etc | ✅ | | | +| [no-test-support-import](docs/rules/no-test-support-import.md) | disallow importing of "test-support" files in production code. | ✅ | | | +| [no-test-this-render](docs/rules/no-test-this-render.md) | disallow usage of the `this.render` in tests, recommending to use @ember/test-helpers' `render` instead. | ✅ | | | +| [no-test-this-set-get](docs/rules/no-test-this-set-get.md) | disallow usage of `this.set`, `this.get`, `this.setProperties`, and `this.getProperties` in `.gjs`/`.gts` tests | | | | +| [prefer-ember-test-helpers](docs/rules/prefer-ember-test-helpers.md) | enforce usage of `@ember/test-helpers` methods over native window methods | ✅ | | | +| [require-valid-css-selector-in-test-helpers](docs/rules/require-valid-css-selector-in-test-helpers.md) | disallow using invalid CSS selectors in test helpers | ✅ | 🔧 | | diff --git a/docs/rules/no-test-this-set-get.md b/docs/rules/no-test-this-set-get.md new file mode 100644 index 0000000000..a7045cd32c --- /dev/null +++ b/docs/rules/no-test-this-set-get.md @@ -0,0 +1,79 @@ +# ember/no-test-this-set-get + + + +In `.gjs`/`.gts` tests, the `