Skip to content

Commit ffc0064

Browse files
committed
Never set DEFAULT_LIBRARY_FUNCS_TO_INCLUDE for side modules. NFC
1 parent ff75baa commit ffc0064

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

emscripten.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,11 @@ def update_settings_glue(metadata, DEBUG):
112112
if settings.SIDE_MODULE:
113113
# we don't need any JS library contents in side modules
114114
settings.DEFAULT_LIBRARY_FUNCS_TO_INCLUDE = []
115-
116-
all_funcs = settings.DEFAULT_LIBRARY_FUNCS_TO_INCLUDE + [shared.JS.to_nice_ident(d) for d in metadata['declares']]
117-
settings.DEFAULT_LIBRARY_FUNCS_TO_INCLUDE = sorted(set(all_funcs).difference(metadata['exports']))
118-
119-
settings.DEFAULT_LIBRARY_FUNCS_TO_INCLUDE += metadata['globalImports']
115+
else:
116+
syms = settings.DEFAULT_LIBRARY_FUNCS_TO_INCLUDE + [shared.JS.to_nice_ident(d) for d in metadata['declares']]
117+
syms = set(syms).difference(metadata['exports'])
118+
syms.update(metadata['globalImports'])
119+
settings.DEFAULT_LIBRARY_FUNCS_TO_INCLUDE = sorted(syms)
120120

121121
settings.WASM_EXPORTS = metadata['exports'] + list(metadata['namedGlobals'].keys())
122122
# Store function exports so that Closure and metadce can track these even in

0 commit comments

Comments
 (0)