Fix test_bootstrap_without_em_config #25754
Merged
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests was broken on systems where the python executable lives in path that also contains clang executable. We were remove PATH elements here, but we cannot remove the one that contains the python executable otherwise the bootstrap script cannot run at all.
sbc100
force-pushed
the
test_bootstrap_without_em_config
branch
from
ec751c9 to
c3f1f5e
Compare
Collaborator
Author
|
This test was failing on my system, I'm not sure for how long. |
juj
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests was broken on systems where the python executable lives in path that also contains clang executable.
We were remove PATH elements here, but we cannot remove the one that contains the python executable otherwise the bootstrap script cannot run at all.