Client.send: raise StreamClosed instead of RuntimeError on closed client?

[jakkdl]

aio-libs/aiobotocore#1085 is working on replacing aiohttp with httpx, and we would like to handle premature client closings as a "retryable exception" without having to catch an exception as wide as RuntimeError. So we propose changing the exception raised on this line to e.g. StreamClosed

httpx/httpx/_client.py

Lines 900 to 901 in 15e21e9

	if self._state == ClientState.CLOSED:
	raise RuntimeError("Cannot send a request, as the client has been closed.")

See aio-libs/aiobotocore#1085 (comment)

[lovelydinosaur]

Thanks for the conversation @jakkdl. ☺️

We could use a custom exception here. I've preferred not to do that because I didn't/don't consider this a catchable case.

is working on replacing aiohttp with httpx, and we would like to handle premature client closings

It's not obvious to me how you're running into this, since aiohttp sensibly enforces strictly context managed client lifetimes.

Edit... Perhaps this helps?... this isn't a retryable network error condition, this is a condition where the Client instance is out-of-scope (?)

[jakkdl]

yeah looking closer at this it indeed doesn't seem relevant for retrying, thank you for the clarification!
@thehesiod if you disagree?