Protect meta page when it's being written

ahrtr · ahrtr · commit 5e27733c7fce · 2025-06-26T11:30:48.000+01:00
Signed-off-by: Benjamin Wang &lt;benjamin.ahrtr@gmail.com&gt;
diff --git a/tx.go b/tx.go
@@ -509,15 +509,19 @@ func (tx *Tx) writeMeta() error {
 	tx.meta.write(p)
 
 	// Write the meta page to file.
+	tx.db.metalock.Lock()
 	if _, err := tx.db.ops.writeAt(buf, int64(p.id)*int64(tx.db.pageSize)); err != nil {
+		tx.db.metalock.Unlock()
 		return err
 	}
 	if !tx.db.NoSync || IgnoreNoSync {
 		// gofail: var beforeSyncMetaPage struct{}
 		if err := fdatasync(tx.db); err != nil {
+			tx.db.metalock.Unlock()
 			return err
 		}
 	}
+	tx.db.metalock.Unlock()
 
 	// Update statistics.
 	tx.stats.IncWrite(1)

Original file line number	Diff line number	Diff line change
`@@ -509,15 +509,19 @@ func (tx *Tx) writeMeta() error {`
`509`	`509`	`tx.meta.write(p)`
`510`	`510`
`511`	`511`	`// Write the meta page to file.`
	`512`	`+ tx.db.metalock.Lock()`
`512`	`513`	`if _, err := tx.db.ops.writeAt(buf, int64(p.id)*int64(tx.db.pageSize)); err != nil {`
	`514`	`+ tx.db.metalock.Unlock()`
`513`	`515`	`return err`
`514`	`516`	`}`
`515`	`517`	`if !tx.db.NoSync \|\| IgnoreNoSync {`
`516`	`518`	`// gofail: var beforeSyncMetaPage struct{}`
`517`	`519`	`if err := fdatasync(tx.db); err != nil {`
	`520`	`+ tx.db.metalock.Unlock()`
`518`	`521`	`return err`
`519`	`522`	`}`
`520`	`523`	`}`
	`524`	`+ tx.db.metalock.Unlock()`
`521`	`525`
`522`	`526`	`// Update statistics.`
`523`	`527`	`tx.stats.IncWrite(1)`