[release-3.6] Reject watch request with -1 revision to prevent invalid resync behavior on uncompacted etcd and make rangeEvents safe against negative revision.

[k8s-infra-cherrypick-robot]

This is an automated cherry-pick of #20693

/assign serathius

[k8s-ci-robot]

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[serathius]

/ok-to-test

[codecov]

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.97%. Comparing base (a061450) to head (3bb4470).
⚠️ Report is 2 commits behind head on release-3.6.

Files with missing lines	Patch %	Lines
server/etcdserver/api/v3rpc/watch.go	83.33%	2 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
server/proxy/grpcproxy/watch.go	93.92% <100.00%> (+93.92%)	⬆️
server/storage/mvcc/watchable_store.go	94.09% <100.00%> (+0.05%)	⬆️
server/etcdserver/api/v3rpc/watch.go	83.23% <83.33%> (+2.21%)	⬆️

... and 53 files with indirect coverage changes

@@               Coverage Diff               @@
##           release-3.6   #20707      +/-   ##
===============================================
+ Coverage        66.07%   68.97%   +2.89%     
===============================================
  Files              420      420              
  Lines            35681    35704      +23     
===============================================
+ Hits             23578    24627    +1049     
+ Misses           10663     9642    -1021     
+ Partials          1440     1435       -5     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a061450...3bb4470. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[serathius]

/retest

/cc @fuweid @siyuanfoundation @ahrtr

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fuweid, k8s-infra-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please ask for approval from serathius. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment