Fix NotebookListScreen stuck when Notebook is not found #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potential conflicts warningThis pull request has changes that are conflicting with the changes in 2 open PRs. #163 Rename RootStackParamList.tsx to NavigationConfig.tsx by @zecakeh (updated 5 minutes ago)
#164 Move linking config to NavigationConfig by @zecakeh (updated Just now)
|
zecakeh
force-pushed
the
fix-notebooklist-notfound
branch
from
fc0d87f to
c4393d2
Compare
Contributor
Author
This was referenced Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced with #146. Happens when a notebook is deleted or the wrong
colUidis provided in the URL on web. There was no way to access the Notebooks list.Tested on web Firefox Linux
Tested on native Android