#8: Fixed the bug (#9)

* Fixed the bug

* Changed to ValueError

* Updated gitflow

* Prepared for the release

Author: umitbuyuksahin

.github/workflows/pytest.yaml

@@ -22,5 +22,5 @@ jobs:
         run: poetry install
       - name: Poetry build
         run: poetry build
-      - name: Poetry run pytest integration tests
+      - name: Poetry run tests
         run: poetry run pytest tests

.github/workflows/release_droid_upload_github_release_assets.yml

@@ -27,5 +27,5 @@ jobs:
         run: poetry install
       - name: Build Poetry
         run: poetry build
-      - name: Poetry run pytest integration tests
+      - name: Poetry run tests
         run: poetry run pytest tests

doc/changes/changelog.md

@@ -1,3 +1,4 @@
 # Changelog
 
+* [0.2.0](changes_0.2.0.md)
 * [0.1.0](changes_0.1.0.md)

doc/changes/changes_0.2.0.md

@@ -0,0 +1,14 @@
+# error-reporting-python 0.2.0, released 2022-03-28
+
+Code Name: Eliminated the nested set warning caused by the error code format
+
+## Summary
+
+In this release, we eliminated the nested set warning caused by the error-code format. 
+Furthermore, in case of having an invalid error code, ValueError is thrown instead of AssertError.
+
+### Bug Fixes
+
+  - #8: Eliminated nested set warning in error code format 
+
+    

exasol_error_reporting_python/__init__.py

@@ -1 +1 @@
-__version__ = '0.1.0'
+__version__ = '0.2.0'

exasol_error_reporting_python/error_message_builder.py

@@ -3,7 +3,7 @@
 from exasol_error_reporting_python.parameters_mapper import ParametersMapper
 from exasol_error_reporting_python.placeholder_handler import PlaceholderHandler
 
-ERROR_CODE_FORMAT = "^[FEW]-[[A-Z][A-Z0-9]+(-[A-Z][A-Z0-9]+)*-[0-9]+$"
+ERROR_CODE_FORMAT = "^[FEW]-[A-Z][A-Z0-9]+(-[A-Z][A-Z0-9]+)*-[0-9]+$"
 
 
 class ErrorMessageBuilder:
@@ -12,7 +12,8 @@ class ErrorMessageBuilder:
     """
 
     def __init__(self, error_code: str):
-        assert re.compile(ERROR_CODE_FORMAT).match(error_code)
+        if not re.compile(ERROR_CODE_FORMAT).match(error_code):
+            raise ValueError(f"{error_code} is an invalid error-code format")
 
         self._error_code = error_code
         self._message_builder = []
@@ -129,4 +130,3 @@ def __str__(self):
             result.append("\n".join(mitigations))
 
         return " ".join(result)
-

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "exasol-error-reporting-python"
-version = "0.1.0"
+version = "0.2.0"
 description = "Exasol Python Error Reporting"
 license = "MIT"
 

setup.py

@@ -9,7 +9,7 @@
 
 setup_kwargs = {
     'name': 'exasol-error-reporting-python',
-    'version': '0.1.0',
+    'version': '0.2.0',
     'description': 'Exasol Python Error Reporting',
     'long_description': '# Error Reporting Python\n\nThis project contains a python library for describing Exasol error messages. \nThis library lets you define errors with a uniform set of attributes. \nFurthermore, the error message  is implemented to be parseable, \nso that you can extract an error catalog from the code.\n\n\n## In a Nutshell\nCreate an error object:\n\n```python\nexa_error_obj = ExaError.message_builder(\'E-TEST-1\')\\\n    .message("Not enough space on device {{device}}.")\\\n    .mitigation("Delete something from {{device}}.")\\\n    .mitigation("Create larger partition.")\\\n    .parameter("device", "/dev/sda1", "name of the device") \n```\n\nUse it as string:\n\n```python\nprint(exa_error_obj)\n```\n\nResult:\n```\nE-TEST-1: Not enough space on device \'/dev/sda1\'. Known mitigations:\n* Delete something from \'/dev/sda1\'.\n* Create larger partition.\n```\n\n\nCheck out the [user guide](doc/user_guide/user_guide.md) for more details.\n\n### Information for Users\n\n* [User Guide](doc/user_guide/user_guide.md)\n* [Changelog](doc/changes/changelog.md)\n\nYou can find corresponding libraries for other languages here:\n\n* [Error reporting Java](https://github.com/exasol/error-reporting-java)\n* [Error reporting Lua](https://github.com/exasol/error-reporting-lua)\n* [Error reporting Go](https://github.com/exasol/error-reporting-go)\n* [Error reporting C#](https://github.com/exasol/error-reporting-csharp)\n\n### Information for Contributors\n\n* [System Requirement Specification](doc/system_requirements.md)\n* [Design](doc/design.md)\n* [Dependencies](doc/dependencies.md)',
     'author': 'Umit Buyuksahin',

tests/test_error_code_format.py

@@ -1,4 +1,7 @@
 import unittest
+
+import pytest
+
 from exasol_error_reporting_python.error_message_builder import \
     ErrorMessageBuilder
 
@@ -14,8 +17,8 @@ def test_invalid_error_code_format(self):
             "F-100"
         ]
         for error_code in invalid_error_code_list:
-            with self.assertRaises(AssertionError):
-                builder = ErrorMessageBuilder(error_code)
+            with pytest.raises(ValueError):
+                assert ErrorMessageBuilder(error_code)
 
     def test_valid_error_code_format(self):
         valid_error_code_list = [