Skip to content

Commit b157876

Browse files
HaoZekergommers
andcommitted
MAINT: Cleanup with reviewer comments
Co-authored-by: rgommers <[email protected]>
1 parent 9b53e14 commit b157876

File tree

3 files changed

+2
-23
lines changed

3 files changed

+2
-23
lines changed

.github/workflows/cibuildwheel.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
steps:
2020
- uses: actions/checkout@v4
2121
- name: Build wheels
22-
uses: pypa/cibuildwheel@v2.21.3
22+
uses: pypa/cibuildwheel@v2.23.3
2323
env:
2424
CIBW_SOME_OPTION: value
2525
with:

README.md

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -48,27 +48,6 @@ pip install cymem
4848
Currently `Pool` is not thread safe when used from multiple threads at once;
4949
**please avoid sharing a single** `Pool` instance between threads.
5050

51-
Also remember to declare `freethreading_compatible` for the example case below:
52-
53-
``` python
54-
from setuptools import setup
55-
from Cython.Build import cythonize
56-
57-
from Cython.Compiler.Version import version as cython_version
58-
from packaging.version import Version
59-
60-
61-
compiler_directives = dict()
62-
63-
if Version(cython_version) >= Version("3.1.0"):
64-
compiler_directives["freethreading_compatible"] = True
65-
66-
setup(
67-
ext_modules = cythonize("*.pyx", language_level=3,
68-
compiler_directives=compiler_directives)
69-
)
70-
```
71-
7251
## Example Use Case: An array of structs
7352

7453
Let's say we want a sequence of sparse matrices. We need fast access, and a

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
compiler_directives = dict()
1919

2020
if Version(cython_version) >= Version("3.1.0"):
21-
compiler_directives["freethreading_compatible"] = rue
21+
compiler_directives["freethreading_compatible"] = True
2222

2323
# By subclassing build_extensions we have the actual compiler that will be used which is really known only after finalize_options
2424
# http://stackoverflow.com/questions/724664/python-distutils-how-to-get-a-compiler-that-is-going-to-be-used

0 commit comments

Comments
 (0)