MAINT: Baseline setup for free-threading #49
Conversation
|
Subsumed the typo PR #48 into this one |
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
Thanks @HaoZeke. Looks largely right. A few small comments.
Also note that the cibuildwheel version needs bumping to the latest released version or the enable = part won't work, here:
cymem/.github/workflows/cibuildwheel.yml
Line 22 in a66af97
| self.matrices = <SparseMatrix**>self.mem.alloc(self.length, sizeof(SparseMatrix*)) | ||
| for i, py_matrix in enumerate(py_matrices): | ||
| self.matrices[i] = sparse_matrix_init(self.mem, py_matrix) | ||
| self.matrices[i] = sparse_matrix_init_cymem(self.mem, py_matrix) |
There was a problem hiding this comment.
It's minor, but this would have been better left as a separate PR, since it's unrelated to the topic of this PR, trivial to review/merge, and after that CI will run on this PR without approval.
Part of the next PR...
Co-authored-by: rgommers <[email protected]>
|
gh-53 is now merged, which addresses free-threading support fully, in a similar but slightly different way. At this point, 3.13t support is no longer needed, 3.14t only is fine. So while this PR was actually ready to go at the time, it now has merge conflicts and doesn't add anything anymore. Hence I will go ahead and close this. Thanks again @HaoZeke. |
2 participants
Implements (1) as suggested by @rgommers in #47 (comment). Basically builds without a warning, but isn't really safe.